Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js

Issue 1933013002: [Media Router WebUI] Remove unnecessary default property values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
index 45f23d282f8a59dfdb91b0e10f322105c16ca625..599c99f86dc57d9289ff5809046e97d2eccde677 100644
--- a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
+++ b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
@@ -10,11 +10,10 @@ Polymer({
/**
* The name of the icon used as the back button. This is set once, when
* the |this| is ready.
- * @private {string}
+ * @private {string|undefined}
*/
arrowDropIcon_: {
type: String,
- value: '',
},
/**
@@ -28,11 +27,10 @@ Polymer({
/**
* The header text to show.
- * @type {string}
+ * @type {string|undefined}
*/
headingText: {
type: String,
- value: '',
},
/**
@@ -57,39 +55,35 @@ Polymer({
/**
* Whether to show the user email in the header.
- * @type {boolean}
+ * @type {boolean|undefined}
*/
showEmail: {
type: Boolean,
- value: false,
observer: 'maybeChangeHeaderHeight_',
},
/**
* The text to show in the tooltip.
- * @type {string}
+ * @type {string|undefined}
*/
tooltip: {
type: String,
- value: '',
},
/**
* The user email if they are signed in.
- * @type {string}
+ * @type {string|undefined}
*/
userEmail: {
type: String,
- value: '',
},
/**
* The current view that this header should reflect.
- * @type {?media_router.MediaRouterView}
+ * @type {?media_router.MediaRouterView|undefined}
*/
view: {
type: String,
- value: null,
observer: 'updateHeaderCursorStyle_',
},
},

Powered by Google App Engine
This is Rietveld 408576698