chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js - Issue 1933013002: [Media Router WebUI] Remove unnecessary default property values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js

Issue 1933013002: [Media Router WebUI] Remove unnecessary default property values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js ('k') | chrome/browser/resources/media_router/elements/route_details/route_details.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js

diff --git a/chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js b/chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js

index 317907f2843fd46247350581db0284e23249eed8..a38aa7f9ef6ce8ef9de974d05f2eee9c5d09db8c 100644

--- a/chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js

+++ b/chrome/browser/resources/media_router/elements/media_router_search_highlighter/media_router_search_highlighter.js

@@ -24,11 +24,11 @@ Polymer({

* null corresponds to an empty string when the arrays are being combined.

* So both examples reproduce the text 'living room', but with different

* words highlighted.

- * @type {{highlightedText: !Array<?string>, plainText: !Array<?string>}}

+ * @type {{highlightedText: !Array<?string>,

+ * plainText: !Array<?string>}|undefined}

data: {

type: Object,

- value: null,

observer: 'dataChanged_',

@@ -36,11 +36,10 @@ Polymer({

* The text that this element is displaying as a plain string. The primary

* purpose for this property is to make getting this element's textContent

* easy for testing.

- * @type {?string}

+ * @type {string|undefined}

text: {

type: String,

- value: null,

readOnly: true,

notify: false,