Clean up test drawContext usage

Clean up test drawContext usage

The general idea is to provide access to SkGpuDevice's drawContext rather than its GrRenderTarget. That is usually what the testing framework actually wants.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1930623003

Committed: https://skia.googlesource.com/skia/+/175dd9b5e3d7d749738dac743d2ac360b5340187

[robertphillips, 2016-04-27 21:41:48]

Description was changed from

==========
Clean up test drawContext usage
==========

to

==========
Clean up test drawContext usage
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-27 22:14:45]

Description was changed from

==========
Clean up test drawContext usage
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Clean up test drawContext usage

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-27 22:14:45]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-04-27 22:14:53]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 22:14:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930623003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930623003/40001

[robertphillips, 2016-04-27 22:17:53]

The marginally interesting bits can be found in:

SkCanvas.h/.cpp
SkDevice.h/
SkGpuDevice.h/.cpp

[robertphillips, 2016-04-27 22:19:21]

Description was changed from

==========
Clean up test drawContext usage

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Clean up test drawContext usage

The general idea is to provide access to SkGpuDevice's drawContext rather than
its GrRenderTarget. That is usually what the testing framework actually wants.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-04-27 22:30:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 22:30:29]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-28 14:24:42]

ping

[bsalomon, 2016-04-28 15:03:35]

overall seems fine, some Qs

https://codereview.chromium.org/1930623003/diff/40001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/1930623003/diff/40001/include/core/SkDevice.h...
include/core/SkDevice.h:109: virtual GrRenderTarget* accessRenderTarget() {
return nullptr; }
Is this still needed?

https://codereview.chromium.org/1930623003/diff/40001/include/core/SkDevice.h...
include/core/SkDevice.h:112: * Don't call this!
When is it OK to call this? Should we say for testing? If device is internal is
this such a bad method to have?

[robertphillips, 2016-04-28 18:49:57]

https://codereview.chromium.org/1930623003/diff/40001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/1930623003/diff/40001/include/core/SkDevice.h...
include/core/SkDevice.h:109: virtual GrRenderTarget* accessRenderTarget() {
return nullptr; }
On 2016/04/28 15:03:34, bsalomon wrote:
> Is this still needed?

Unfortunately, draw_filter_into_device still calls the virtual version. Once
that is cleaned up the virtual can go away.

I've added a TODO.

https://codereview.chromium.org/1930623003/diff/40001/include/core/SkDevice.h...
include/core/SkDevice.h:112: * Don't call this!
On 2016/04/28 15:03:34, bsalomon wrote:
> When is it OK to call this? Should we say for testing? If device is internal
is
> this such a bad method to have?

It is testing-only except for MultiPictureDraw (where it is used to get the
numSamples needed for the hoisted layers) and VisualBench (where it is used for
a faster blit). 

The comment is more a prayer that it not become the new accessRenderTarget.

[bsalomon, 2016-04-28 18:54:08]

lgtm, if you care virtaul is misspelled in the new comment.

[robertphillips, 2016-04-28 18:57:23]

On 2016/04/28 18:54:08, bsalomon wrote:
> lgtm, if you care virtaul is misspelled in the new comment.

Fixed.

[robertphillips, 2016-04-28 18:57:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 18:57:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930623003/80001

[commit-bot: I haz the power, 2016-04-28 19:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 19:00:17]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[robertphillips, 2016-04-28 19:23:46]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 19:23:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930623003/80001

[commit-bot: I haz the power, 2016-04-28 19:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 19:26:19]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[robertphillips, 2016-04-28 19:27:36]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 19:27:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930623003/80001

[commit-bot: I haz the power, 2016-04-28 19:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 19:28:29]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[robertphillips, 2016-04-28 21:27:49]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 21:27:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930623003/80001

[commit-bot: I haz the power, 2016-04-28 21:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 21:28:48]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-28 21:30:57]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-28 21:30:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1930623003/#ps80001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-04-28 21:31:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930623003/80001

[commit-bot: I haz the power, 2016-04-28 21:32:08]

Description was changed from

==========
Clean up test drawContext usage

The general idea is to provide access to SkGpuDevice's drawContext rather than
its GrRenderTarget. That is usually what the testing framework actually wants.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Clean up test drawContext usage

The general idea is to provide access to SkGpuDevice's drawContext rather than
its GrRenderTarget. That is usually what the testing framework actually wants.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/175dd9b5e3d7d749738dac743d2ac360b5340187
==========

[commit-bot: I haz the power, 2016-04-28 21:32:09]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/175dd9b5e3d7d749738dac743d2ac360b5340187