Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1930473002: Revert of Build: disable icf for gcc builds with bundled gold (Closed)

Created:
4 years, 7 months ago by pasko
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build: disable icf for gcc builds with bundled gold (patchset #2 id:20001 of https://codereview.chromium.org/1887303003/ ) Reason for revert: Seems to be causing a 2.5MiB regression in libchrome.so on Android/ARM. Please re-land with disabling ICF for Linux-only. See: crbug.com/605494 Original issue's description: > Build: disable icf for gcc builds with bundled gold > > Gold doesn't respect section alignment when merging symbols > https://sourceware.org/bugzilla/show_bug.cgi?id=17704 > > BUG=576197 > > Committed: https://crrev.com/feea41a011671a28dd15e2bb1d1290d817d601c0 > Cr-Commit-Position: refs/heads/master@{#388437} TBR=dpranke@chromium.org,mcgrathr@chromium.org,ljagielski@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=576197 Committed: https://crrev.com/a5cd3c9a6ab2ce65e3775064893182ac42f305e9 Cr-Commit-Position: refs/heads/master@{#390057}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pasko
Created Revert of Build: disable icf for gcc builds with bundled gold
4 years, 7 months ago (2016-04-27 12:10:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930473002/1
4 years, 7 months ago (2016-04-27 12:10:40 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/25777) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-04-27 12:12:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930473002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930473002/70001
4 years, 7 months ago (2016-04-27 12:25:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 7 months ago (2016-04-27 13:20:15 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 13:21:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5cd3c9a6ab2ce65e3775064893182ac42f305e9
Cr-Commit-Position: refs/heads/master@{#390057}

Powered by Google App Engine
This is Rietveld 408576698