Revert of Build: disable icf for gcc builds with bundled gold

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/nacl/config.gni")
 import("//build/toolchain/cc_wrapper.gni")
 import("//build/toolchain/toolchain.gni")
@@ skipping 69 matching lines @@
   # If true, gold linker will save symbol table inside object files.
   # This speeds up gdb startup by 60%
   gdb_index = false
 
   # If true, optimize for size. Does not affect windows builds.
   # Linux & Mac favor speed over size.
   # TODO(brettw) it's weird that Mac and desktop Linux are different. We should
   # explore favoring size over speed in this case as well.
   optimize_for_size = is_android || is_ios
 
-  # Gold icf level, values are "none", "safe", "all". If value isn't overridden,
-  # default initialization is below.
-  gold_icf_level = ""
-
   # If this is set to true, or if LLVM_FORCE_HEAD_REVISION is set to 1
   # in the environment, we use the revision in the llvm repo to determine
   # the CLANG_REVISION to use, instead of the version hard-coded into
   # //tools/clang/scripts/update.py. This should only be used in
   # conjunction with setting LLVM_FORCE_HEAD_REVISION in the
   # environment when `gclient runhooks` is run as well.
   llvm_force_head_revision = false
 }
 
 if (is_clang && !is_nacl) {
@@ skipping 13 matching lines @@
   } else {
     gold_path = ""
   }
 }
 
 if (use_debug_fission == "default") {
   use_debug_fission = is_debug && !is_win && use_gold &&
                       linux_use_bundled_binutils && cc_wrapper == ""
 }
 
-if (gold_icf_level == "") {
-  if (use_gold && !is_clang) {
-    # Gold doesn't respect section alignment and breaks gcc builds with icf
-    # https://bugs.chromium.org/p/chromium/issues/detail?id=576197
-    gold_icf_level = "none"
-  } else {
-    gold_icf_level = "all"
-  }
-}
-
 # default_include_dirs ---------------------------------------------------------
 #
 # This is a separate config so that third_party code (which would not use the
 # source root and might have conflicting versions of some headers) can remove
 # this and specify their own include paths.
 config("default_include_dirs") {
   include_dirs = [
     "//",
     root_gen_dir,
   ]
@@ skipping 178 matching lines @@
       #"-Wl,--threads",
       #"-Wl,--thread-count=4",
     ]
 
     if (gdb_index) {
       ldflags += [ "-Wl,--gdb-index" ]
     }
 
     if (!using_sanitizer && !(is_android && use_order_profiling)) {
       # TODO(brettw) common.gypi has this only for target toolset.
-      ldflags += [ "-Wl,--icf=${gold_icf_level}" ]
+      ldflags += [ "-Wl,--icf=all" ]
     }
 
     # TODO(thestig): Make this flag work with GN.
     #if (!is_official_build && !is_chromeos && !(is_asan || is_lsan || is_tsan || is_msan)) {
     #  ldflags += [
     #    "-Wl,--detect-odr-violations",
     #  ]
     #}
   } else if (linux_use_bundled_binutils) {
     # Gold is the default linker for the bundled binutils so we explicitly
@@ skipping 1089 matching lines @@
 
 if (is_ios || is_mac) {
   # On Mac and iOS, this enables support for ARC (automatic ref-counting).
   # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
   config("enable_arc") {
     common_flags = [ "-fobjc-arc" ]
     cflags_objc = common_flags
     cflags_objcc = common_flags
   }
 }