Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: build/common.gypi

Issue 1930473002: Revert of Build: disable icf for gcc builds with bundled gold (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2445 matching lines...) Expand 10 before | Expand all | Expand 10 after
2456 2456
2457 ['cfi_vptr==1', { 2457 ['cfi_vptr==1', {
2458 'use_lto%': 1, 2458 'use_lto%': 1,
2459 }], 2459 }],
2460 2460
2461 ['branding=="Chrome" and buildtype=="Official"', { 2461 ['branding=="Chrome" and buildtype=="Official"', {
2462 'enable_hangout_services_extension%': 1, 2462 'enable_hangout_services_extension%': 1,
2463 }, { 2463 }, {
2464 'enable_hangout_services_extension%': 0, 2464 'enable_hangout_services_extension%': 0,
2465 }], 2465 }],
2466
2467 # Gold doesn't respect section alignment and breaks gcc builds with icf
2468 # https://bugs.chromium.org/p/chromium/issues/detail?id=576197
2469 ['clang==0 and linux_use_bundled_gold==1', {
2470 'gold_icf_level%': 'none'
2471 }],
2472 ], 2466 ],
2473 2467
2474 # The path to the ANGLE library. 2468 # The path to the ANGLE library.
2475 'angle_path': '<(DEPTH)/third_party/angle', 2469 'angle_path': '<(DEPTH)/third_party/angle',
2476 2470
2477 # List of default apps to install in new profiles. The first list contains 2471 # List of default apps to install in new profiles. The first list contains
2478 # the source files as found in svn. The second list, used only for linux, 2472 # the source files as found in svn. The second list, used only for linux,
2479 # contains the destination location for each of the files. When a crx 2473 # contains the destination location for each of the files. When a crx
2480 # is added or removed from the list, the chrome/browser/resources/ 2474 # is added or removed from the list, the chrome/browser/resources/
2481 # default_apps/external_extensions.json file must also be updated. 2475 # default_apps/external_extensions.json file must also be updated.
(...skipping 3831 matching lines...) Expand 10 before | Expand all | Expand 10 after
6313 # settings in target dicts. SYMROOT is a special case, because many other 6307 # settings in target dicts. SYMROOT is a special case, because many other
6314 # Xcode variables depend on it, including variables such as 6308 # Xcode variables depend on it, including variables such as
6315 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6309 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6316 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6310 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6317 # files to appear (when present) in the UI as actual files and not red 6311 # files to appear (when present) in the UI as actual files and not red
6318 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6312 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6319 # and therefore SYMROOT, needs to be set at the project level. 6313 # and therefore SYMROOT, needs to be set at the project level.
6320 'SYMROOT': '<(DEPTH)/xcodebuild', 6314 'SYMROOT': '<(DEPTH)/xcodebuild',
6321 }, 6315 },
6322 } 6316 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698