Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1929653002: Remove manual check using Rietveld for dry run. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@P200
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove manual check using Rietveld for dry run. It's now passed using command line flags. This depends on https://codereview.chromium.org/1931633002, which actually uses this command line flag. R=sergiyb@chromium.org,phajdan.jr@chromium.org BUG=601128 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M presubmit_canned_checks.py View 1 chunk +1 line, -4 lines 0 comments Download
M tests/presubmit_unittest.py View 4 chunks +5 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1923623004 Patch 20001

Dependent Patchsets:

Issue 1927773002 Patch 1
Issue 1927773002 Patch 20001

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
4 years, 7 months ago (2016-04-27 20:19:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929653002/1
4 years, 7 months ago (2016-04-27 20:19:19 UTC) #3
Sergiy Byelozyorov
lgtm
4 years, 7 months ago (2016-04-27 20:20:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 20:21:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929653002/1
4 years, 7 months ago (2016-04-28 06:23:49 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 06:26:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300268

Powered by Google App Engine
This is Rietveld 408576698