presubmit_canned_checks.py - Issue 1929653002: Remove manual check using Rietveld for dry run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 1929653002: Remove manual check using Rietveld for dry run. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@P200

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index e63b798a32780f3e6dc317f93ba72b4882be6b4d..e21d08675f27849a0a40a1a580908a36b2826d3e 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -859,10 +859,7 @@ def CheckOwners(input_api, output_api, source_file_filter=None):

return [output_api.PresubmitNotifyResult(

'--tbr was specified, skipping OWNERS check')]

if input_api.change.issue:

- if (input_api.dry_run or

- # TODO(tandrii): clean below once CQ && run_presubmit.py recipe specify

- # dry_run property. http://crbug.com/605563.

- _GetRietveldIssueProps(input_api, None).get('cq_dry_run', False)):

+ if input_api.dry_run:

return [output_api.PresubmitNotifyResult(

'This is a dry run, skipping OWNERS check')]

else:

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »