Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1923623004: Add --dry_run to presubmit_support. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --dry_run to presubmit_support. Also, implement skipping of CheckOwners presumbit canned check. To be used by run_presubmit recipe in build repo in https://codereview.chromium.org/1931633002 R=sergiyb@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org BUG=594127 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300262

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M presubmit_canned_checks.py View 2 chunks +6 lines, -2 lines 0 comments Download
M presubmit_support.py View 10 chunks +25 lines, -14 lines 0 comments Download
M tests/presubmit_unittest.py View 1 4 chunks +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923623004/1
4 years, 7 months ago (2016-04-27 19:19:50 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/362)
4 years, 7 months ago (2016-04-27 19:24:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923623004/20001
4 years, 7 months ago (2016-04-27 19:31:16 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 19:33:23 UTC) #8
Sergiy Byelozyorov
lgtm
4 years, 7 months ago (2016-04-27 21:10:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923623004/20001
4 years, 7 months ago (2016-04-28 05:06:27 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300262
4 years, 7 months ago (2016-04-28 05:09:05 UTC) #15
Michael Achenbach
4 years, 7 months ago (2016-04-28 06:28:08 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698