Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1931633002: Make use of dry_run property of presubmit tryjobs. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make use of dry_run property of presubmit tryjobs. dry_run is set by CQ when in dry run mode, and also by Rietveld and soon in case of manual git cl try (https://codereview.chromium.org/1926663002). dry_run is then passed onto presubmit_support script, which is then exposed in PRESUBMIT's input_api. Example use case: skipping owners check. Depends on: https://codereview.chromium.org/1923623004/, which adds --dry-run to presubmit_support. R=phajdan.jr@chromium.org,machenbach@chromium.org BUG=594127 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M scripts/slave/recipes/run_presubmit.py View 2 chunks +14 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tandrii(chromium)
4 years, 7 months ago (2016-04-27 19:27:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931633002/1
4 years, 7 months ago (2016-04-27 19:28:02 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 19:31:51 UTC) #5
Michael Achenbach
lgtm
4 years, 7 months ago (2016-04-27 20:24:51 UTC) #6
tandrii(chromium)
The dependent change has been rolled into build: https://codereview.chromium.org/1932633002/ Landing this one.
4 years, 7 months ago (2016-04-28 05:21:15 UTC) #8
tandrii(chromium)
Roll of dependency landed into build, so landing this.
4 years, 7 months ago (2016-04-28 05:26:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931633002/1
4 years, 7 months ago (2016-04-28 05:26:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300264
4 years, 7 months ago (2016-04-28 05:30:54 UTC) #13
tandrii(chromium)
4 years, 7 months ago (2016-04-28 05:37:32 UTC) #14
Message was sent while issue was closed.
this went well!
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...
is green after this landed and I can see that message changed from "CQ dry run"
to dry run.

Powered by Google App Engine
This is Rietveld 408576698