Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1927973004: Use TraceProviderRegistry in //mojo/common/tracing_impl.*. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use TraceProviderRegistry in //mojo/common/tracing_impl.*. Make the tracing service/app tolerate not being given a "wrong way" ServiceProvider (which is important, since we're going to remove them altogether -- e.g., the new tracing_impl.* no longer provide a "wrong way" ServiceProvider). (I still have to track down any other users of the old code path (via "wrong way" ServiceProvider), and maybe update monet, etc.) R=jamesr@chromium.org BUG=#763 Committed: https://chromium.googlesource.com/external/mojo/+/996f2ba7b02f3cc69c06863e0d6259b616d307a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -24 lines) Patch
M mojo/common/tracing_impl.h View 1 chunk +2 lines, -11 lines 0 comments Download
M mojo/common/tracing_impl.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M services/tracing/tracing_app.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-04-28 22:41:04 UTC) #1
jamesr
lgtm
4 years, 7 months ago (2016-04-28 22:58:54 UTC) #2
viettrungluu
4 years, 7 months ago (2016-04-28 23:01:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
996f2ba7b02f3cc69c06863e0d6259b616d307a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698