Use TraceProviderRegistry in //services/dart/dart_tracing.*.

Use TraceProviderRegistry in //services/dart/dart_tracing.*.

R=jamesr@chromium.org
BUG=#763

Committed: https://chromium.googlesource.com/external/mojo/+/75ae018a5b9214a375d0acbd7bd657e534a0bde2

[jamesr, 2016-04-28 23:00:28]

lgtm

https://codereview.chromium.org/1928183002/diff/40001/services/dart/dart_trac...
File services/dart/dart_tracing.cc (right):

https://codereview.chromium.org/1928183002/diff/40001/services/dart/dart_trac...
services/dart/dart_tracing.cc:142:
registry->RegisterTraceProvider(provider.Pass());
this feels like a buncha code that may be repeated a lot with different versions
of |provider_impl_|.  Maybe //mojo/common/ could provide an implementation of
the hookup that just needs a tracing::TraceProvider* ?

https://codereview.chromium.org/1928183002/diff/40001/services/gfx/compositor...
File services/gfx/compositor/compositor_app.h (right):

https://codereview.chromium.org/1928183002/diff/40001/services/gfx/compositor...
services/gfx/compositor/compositor_app.h:15: #include
"mojo/public/cpp/application/interface_factory.h"
these are unrelated fixes, right?

[viettrungluu, 2016-04-28 23:03:28]

Thanks.

On 2016/04/28 23:00:28, jamesr wrote:
> lgtm
> 
>
https://codereview.chromium.org/1928183002/diff/40001/services/dart/dart_trac...
> File services/dart/dart_tracing.cc (right):
> 
>
https://codereview.chromium.org/1928183002/diff/40001/services/dart/dart_trac...
> services/dart/dart_tracing.cc:142:
> registry->RegisterTraceProvider(provider.Pass());
> this feels like a buncha code that may be repeated a lot with different
versions
> of |provider_impl_|.  Maybe //mojo/common/ could provide an implementation of
> the hookup that just needs a tracing::TraceProvider* ?

Yeah. I'll do something like that separately.

> 
>
https://codereview.chromium.org/1928183002/diff/40001/services/gfx/compositor...
> File services/gfx/compositor/compositor_app.h (right):
> 
>
https://codereview.chromium.org/1928183002/diff/40001/services/gfx/compositor...
> services/gfx/compositor/compositor_app.h:15: #include
> "mojo/public/cpp/application/interface_factory.h"
> these are unrelated fixes, right?

I removed an unneeded include from tracing_impl.h, and some yaks got antsy.

[viettrungluu, 2016-04-28 23:05:31]

Description was changed from

==========
Use TraceProviderRegistry in //services/dart/dart_tracing.*.

R=jamesr@chromium.org
BUG=#763
==========

to

==========
Use TraceProviderRegistry in //services/dart/dart_tracing.*.

R=jamesr@chromium.org
BUG=#763

Committed:
https://chromium.googlesource.com/external/mojo/+/75ae018a5b9214a375d0acbd7bd...
==========

[viettrungluu, 2016-04-28 23:05:33]

Committed patchset #3 (id:40001) manually as
75ae018a5b9214a375d0acbd7bd657e534a0bde2 (presubmit successful).