Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Side by Side Diff: services/tracing/tracing_app.cc

Issue 1927973004: Use TraceProviderRegistry in //mojo/common/tracing_impl.*. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/common/tracing_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/tracing/tracing_app.h" 5 #include "services/tracing/tracing_app.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "mojo/public/cpp/system/wait.h" 10 #include "mojo/public/cpp/system/wait.h"
11 11
12 namespace tracing { 12 namespace tracing {
13 13
14 TracingApp::TracingApp() : collector_binding_(this), tracing_active_(false) {} 14 TracingApp::TracingApp() : collector_binding_(this), tracing_active_(false) {}
15 15
16 TracingApp::~TracingApp() {} 16 TracingApp::~TracingApp() {}
17 17
18 bool TracingApp::ConfigureIncomingConnection( 18 bool TracingApp::ConfigureIncomingConnection(
19 mojo::ApplicationConnection* connection) { 19 mojo::ApplicationConnection* connection) {
20 connection->AddService<TraceCollector>(this); 20 connection->AddService<TraceCollector>(this);
21 21
22 // If someone connects to us they may want to use the TraceCollector 22 // If someone connects to us they may want to use the TraceCollector
23 // interface and/or they may want to expose themselves to be traced. Attempt 23 // interface and/or they may want to expose themselves to be traced. Attempt
24 // to connect to the TraceProvider interface to see if the application 24 // to connect to the TraceProvider interface to see if the application
25 // connecting to us wants to be traced. They can refuse the connection or 25 // connecting to us wants to be traced. They can refuse the connection or
26 // close the pipe if not. 26 // close the pipe if not.
27 // TODO(vtl): Remove this once we remove the "wrong way" ServiceProvider. 27 // TODO(vtl): Remove this once we remove the "wrong way" ServiceProvider.
28 TraceProviderPtr provider_ptr; 28 TraceProviderPtr provider_ptr;
29 connection->ConnectToService(&provider_ptr); 29 connection->ConnectToService(&provider_ptr);
30 RegisterTraceProvider(provider_ptr.PassInterfaceHandle()); 30 if (provider_ptr)
31 RegisterTraceProvider(provider_ptr.PassInterfaceHandle());
31 32
32 return true; 33 return true;
33 } 34 }
34 35
35 void TracingApp::Create(mojo::ApplicationConnection* connection, 36 void TracingApp::Create(mojo::ApplicationConnection* connection,
36 mojo::InterfaceRequest<TraceCollector> request) { 37 mojo::InterfaceRequest<TraceCollector> request) {
37 if (collector_binding_.is_bound()) { 38 if (collector_binding_.is_bound()) {
38 LOG(ERROR) << "Another application is already connected to tracing."; 39 LOG(ERROR) << "Another application is already connected to tracing.";
39 return; 40 return;
40 } 41 }
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 } 137 }
137 provider_ptrs_.AddInterfacePtr(provider_ptr.Pass()); 138 provider_ptrs_.AddInterfacePtr(provider_ptr.Pass());
138 } 139 }
139 140
140 void TracingApp::AllDataCollected() { 141 void TracingApp::AllDataCollected() {
141 recorder_impls_.clear(); 142 recorder_impls_.clear();
142 sink_.reset(); 143 sink_.reset();
143 } 144 }
144 145
145 } // namespace tracing 146 } // namespace tracing
OLDNEW
« no previous file with comments | « mojo/common/tracing_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698