services/tracing/tracing_app.cc - Issue 1927973004: Use TraceProviderRegistry in //mojo/common/tracing_impl.*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/tracing/tracing_app.cc

Issue 1927973004: Use TraceProviderRegistry in //mojo/common/tracing_impl.*. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/tracing/tracing_app.cc

diff --git a/services/tracing/tracing_app.cc b/services/tracing/tracing_app.cc

index 18a2ea4a96a9af8828f41342e4b56d86469aaa86..930c5e5974dd3f505c9c1c458a62bce44a42feab 100644

--- a/services/tracing/tracing_app.cc

+++ b/services/tracing/tracing_app.cc

@@ -27,7 +27,8 @@ bool TracingApp::ConfigureIncomingConnection(

// TODO(vtl): Remove this once we remove the "wrong way" ServiceProvider.

TraceProviderPtr provider_ptr;

connection->ConnectToService(&provider_ptr);

- RegisterTraceProvider(provider_ptr.PassInterfaceHandle());

+ if (provider_ptr)

+ RegisterTraceProvider(provider_ptr.PassInterfaceHandle());

return true;

}

« no previous file with comments | « mojo/common/tracing_impl.cc ('k') | no next file » | no next file with comments »