Support compilation of Hello World

Support compilation of Hello World

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b361d8ce97d555638be94369dc3ee62e365614b3

[Johnni Winther, 2016-04-28 14:28:09]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-04-28 17:23:15]

lgtm

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:704: return elements.toList();
//..sort(compareByPosition);
uncomment?

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:313:
!compiler.serialization.isDeserialized(superclass)) {
trying to understand this part of the change:
 - synthesized classes weren't checked before but now they are?
 - deserialized classes are not checked anymore? (is that because  they were
checked when they were built?)

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/modelz.dart (right):

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/modelz.dart:1118: // relations?
it might not be worth while. We can fail early and not produce serialized output
if there are errors in the code.

https://codereview.chromium.org/1927963002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization_compilation_test.dart (right):

https://codereview.chromium.org/1927963002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization_compilation_test.dart:32: for (Test test in
TESTS.sublist(0, 2)) {
woo hoo! :)

[Johnni Winther, 2016-04-29 09:31:37]

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:704: return elements.toList();
//..sort(compareByPosition);
On 2016/04/28 17:23:15, Siggi Cherem (dart-lang) wrote:
> uncomment?

Good idea ;-)

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:313:
!compiler.serialization.isDeserialized(superclass)) {
On 2016/04/28 17:23:15, Siggi Cherem (dart-lang) wrote:
> trying to understand this part of the change:
>  - synthesized classes weren't checked before but now they are?
>  - deserialized classes are not checked anymore? (is that because  they were
> checked when they were built?)

All deserialized element returned `true` on [isSynthesized] which wasn't
consistent with modelx. Now have (the crude) [isDeserialized] to query instead.
(And [isSynthesized] is now consistent with modelx)

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/modelz.dart (right):

https://codereview.chromium.org/1927963002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/modelz.dart:1118: // relations?
On 2016/04/28 17:23:15, Siggi Cherem (dart-lang) wrote:
> it might not be worth while. We can fail early and not produce serialized
output
> if there are errors in the code.

They will be needed for warnings such as a call to `print` with too many
arguments.

[Johnni Winther, 2016-04-29 10:57:51]

Description was changed from

==========
Support compilation of Hello World

BUG=
==========

to

==========
Support compilation of Hello World

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b361d8ce97d555638be94369dc3ee62e365614b3
==========

[Johnni Winther, 2016-04-29 10:57:52]

Committed patchset #4 (id:60001) manually as
b361d8ce97d555638be94369dc3ee62e365614b3 (presubmit successful).