pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart - Issue 1927963002: Support compilation of Hello World

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

Issue 1927963002: Support compilation of Hello World (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart b/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

index 3bc94e5eb070cbed11303a4f6bf3cbe91b99acca..23836625b66880663aed375abf8a8cfb25a6aeb1 100644

--- a/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

@@ -245,7 +245,11 @@ class JavaScriptConstantCompiler extends ConstantCompilerBase

}

+ @override

ConstantValue getConstantValue(ConstantExpression expression) {

+ assert(invariant(CURRENT_ELEMENT_SPANNABLE, expression != null,

+ message: "ConstantExpression is null in getConstantValue."));

+ evaluate(expression);

ConstantValue value = super.getConstantValue(expression);

if (value == null &&

expression != null &&