pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart - Issue 1927963002: Support compilation of Hello World

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1927963002: Support compilation of Hello World (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

index 49d3353c24f60c65fe9d1d3d95b8fa79575096c2..e7595b4edf6ce7356be00eba242a431ba46ed1e9 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

@@ -1681,7 +1681,11 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>

}

ConstantValue getConstantForVariable(VariableElement element) {

- return irBuilder.state.constants.getConstantValue(element.constant);

+ ConstantExpression constant = element.constant;

+ if (constant != null) {

+ return irBuilder.state.constants.getConstantValue(constant);

+ }

+ return null;

}

ir.Primitive buildConstantExpression(