pkg/compiler/lib/src/constants/constant_system.dart - Issue 1927963002: Support compilation of Hello World

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/constant_system.dart

Issue 1927963002: Support compilation of Hello World (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/constant_system.dart

diff --git a/pkg/compiler/lib/src/constants/constant_system.dart b/pkg/compiler/lib/src/constants/constant_system.dart

index aae267f05601f31c676406e47684b731c384522b..e2786128e572e7dd89cba3272e6718cbaa5e2380 100644

--- a/pkg/compiler/lib/src/constants/constant_system.dart

+++ b/pkg/compiler/lib/src/constants/constant_system.dart

@@ -68,6 +68,8 @@ abstract class ConstantSystem {

List<ConstantValue> keys, List<ConstantValue> values);

// TODO(johnniwinther): Remove the need for [compiler].

ConstantValue createType(Compiler compiler, DartType type);

+ // TODO(johnniwinther): Remove the need for [compiler].

+ ConstantValue createSymbol(Compiler compiler, String text);

// We need to special case the subtype check for JavaScript constant

// system because an int is a double at runtime.