👓 Don't run android_lint() on targets that have only generated files.

Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none

Committed: https://crrev.com/24e6283f45ba82deef8011b4b013d63b9c8bc40c
Cr-Commit-Position: refs/heads/master@{#390178}

[agrieve, 2016-04-27 17:13:42]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 17:13:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926803002/1

[agrieve, 2016-04-27 17:37:47]

Description was changed from

==========
Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none
==========

to

==========
Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none
==========

[agrieve, 2016-04-27 17:37:47]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2016-04-27 17:37:52]

On 2016/04/27 17:13:57, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1926803002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1926803002/1

[commit-bot: I haz the power, 2016-04-27 18:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 18:17:15]

Dry run: This issue passed the CQ dry run.

[Yaron, 2016-04-27 18:59:53]

https://codereview.chromium.org/1926803002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1926803002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:1627: _emma_never_instrument =
!_chromium_code
what about possible side-effects for emma? don't care cause it's broken-ish?

[agrieve, 2016-04-27 19:09:29]

https://codereview.chromium.org/1926803002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1926803002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:1627: _emma_never_instrument =
!_chromium_code
On 2016/04/27 18:59:53, Yaron wrote:
> what about possible side-effects for emma? don't care cause it's broken-ish?

I'd guess we don't care about coverage for generated files. We could always
revisit if anyone takes coverage seriously. Updated comment to mention emma as
well.

[Yaron, 2016-04-27 19:17:20]

lgtm

[agrieve, 2016-04-27 19:42:29]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-27 19:43:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926803002/20001

[commit-bot: I haz the power, 2016-04-27 20:53:00]

Description was changed from

==========
Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none
==========

to

==========
Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none
==========

[commit-bot: I haz the power, 2016-04-27 20:53:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:12:52]

Patchset 2 (id:??) landed as
https://crrev.com/24e6283f45ba82deef8011b4b013d63b9c8bc40c
Cr-Commit-Position: refs/heads/master@{#390178}

[commit-bot: I haz the power, 2016-04-30 17:51:47]

Description was changed from

==========
Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none
==========

to

==========
Don't run android_lint() on targets that have only generated files.

Most notably - foo_apk__java targets.

BUG=none

Committed: https://crrev.com/24e6283f45ba82deef8011b4b013d63b9c8bc40c
Cr-Commit-Position: refs/heads/master@{#390178}
==========