Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1926803002: 👓 Don't run android_lint() on targets that have only generated files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/zip.gni") 7 import("//build/config/zip.gni")
8 import("//third_party/ijar/ijar.gni") 8 import("//third_party/ijar/ijar.gni")
9 9
10 assert(is_android) 10 assert(is_android)
(...skipping 1600 matching lines...) Expand 10 before | Expand all | Expand 10 after
1611 defined(invoker.requires_android) && invoker.requires_android 1611 defined(invoker.requires_android) && invoker.requires_android
1612 assert(_requires_android || true) # Mark as used. 1612 assert(_requires_android || true) # Mark as used.
1613 _android_manifest = "//build/android/AndroidManifest.xml" 1613 _android_manifest = "//build/android/AndroidManifest.xml"
1614 if (defined(invoker.android_manifest)) { 1614 if (defined(invoker.android_manifest)) {
1615 _android_manifest = invoker.android_manifest 1615 _android_manifest = invoker.android_manifest
1616 } 1616 }
1617 assert(_android_manifest != "") # Mark as used. 1617 assert(_android_manifest != "") # Mark as used.
1618 _run_findbugs = defined(invoker.run_findbugs) && invoker.run_findbugs 1618 _run_findbugs = defined(invoker.run_findbugs) && invoker.run_findbugs
1619 assert(_run_findbugs || true) # Mark as used. 1619 assert(_run_findbugs || true) # Mark as used.
1620 1620
1621 _chromium_code = true 1621 # Don't enable coverage, lint, findbugs unless the target has some
1622 # non-generated files.
1623 _chromium_code = defined(invoker.java_files) && invoker.java_files != []
1622 if (defined(invoker.chromium_code)) { 1624 if (defined(invoker.chromium_code)) {
1623 _chromium_code = invoker.chromium_code 1625 _chromium_code = invoker.chromium_code
1624 } 1626 }
1625 1627
1626 _emma_never_instrument = !_chromium_code 1628 _emma_never_instrument = !_chromium_code
1627 if (defined(invoker.emma_never_instrument)) { 1629 if (defined(invoker.emma_never_instrument)) {
1628 _emma_never_instrument = invoker.emma_never_instrument 1630 _emma_never_instrument = invoker.emma_never_instrument
1629 } 1631 }
1630 assert(_emma_never_instrument || true) # Mark as used 1632 assert(_emma_never_instrument || true) # Mark as used
1631 _emma_instrument = emma_coverage && !_emma_never_instrument 1633 _emma_instrument = emma_coverage && !_emma_never_instrument
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
2229 2231
2230 args = [ 2232 args = [
2231 "--depfile", 2233 "--depfile",
2232 rebase_path(depfile, root_build_dir), 2234 rebase_path(depfile, root_build_dir),
2233 "--script-output-path", 2235 "--script-output-path",
2234 rebase_path(generated_script, root_build_dir), 2236 rebase_path(generated_script, root_build_dir),
2235 ] 2237 ]
2236 args += test_runner_args 2238 args += test_runner_args
2237 } 2239 }
2238 } 2240 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698