Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1709)

Unified Diff: build/config/android/internal_rules.gni

Issue 1926803002: 👓 Don't run android_lint() on targets that have only generated files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index d0584bd7b50ace14516a73e5f9761217cfa3ee1b..2c5586c802aa6b9141624f75cdcfa73c0aee9677 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -1618,7 +1618,9 @@ template("java_library_impl") {
_run_findbugs = defined(invoker.run_findbugs) && invoker.run_findbugs
assert(_run_findbugs || true) # Mark as used.
- _chromium_code = true
+ # Don't enable coverage, lint, findbugs unless the target has some
+ # non-generated files.
+ _chromium_code = defined(invoker.java_files) && invoker.java_files != []
if (defined(invoker.chromium_code)) {
_chromium_code = invoker.chromium_code
}
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698