👓 Don't run android_lint() on targets that have only generated files.

build/config/android/internal_rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/zip.gni")
 import("//third_party/ijar/ijar.gni")
 
 assert(is_android)
@@ skipping 1600 matching lines @@
       defined(invoker.requires_android) && invoker.requires_android
   assert(_requires_android || true)  # Mark as used.
   _android_manifest = "//build/android/AndroidManifest.xml"
   if (defined(invoker.android_manifest)) {
     _android_manifest = invoker.android_manifest
   }
   assert(_android_manifest != "")  # Mark as used.
   _run_findbugs = defined(invoker.run_findbugs) && invoker.run_findbugs
   assert(_run_findbugs || true)  # Mark as used.
 
-  _chromium_code = true
+  # Don't enable lint & findbugs unless the target has some non-generated files.
+  _chromium_code = defined(invoker.java_files) && invoker.java_files != []
   if (defined(invoker.chromium_code)) {
     _chromium_code = invoker.chromium_code
   }
 
   _emma_never_instrument = !_chromium_code

[Yaron, 2016/04/27 18:59:53]

what about possible side-effects for emma? don't care cause it's broken-ish?

[agrieve, 2016/04/27 19:09:29]

I'd guess we don't care about coverage for generated files. We could always
revisit if anyone takes coverage seriously. Updated comment to mention emma as
well.

   if (defined(invoker.emma_never_instrument)) {
     _emma_never_instrument = invoker.emma_never_instrument
   }
   assert(_emma_never_instrument || true)  # Mark as used
   _emma_instrument = emma_coverage && !_emma_never_instrument
 
   if (_supports_android) {
     _dex_path = _base_path + ".dex.jar"
     if (defined(invoker.dex_path)) {
       _dex_path = invoker.dex_path
@@ skipping 592 matching lines @@
 
     args = [
       "--depfile",
       rebase_path(depfile, root_build_dir),
       "--script-output-path",
       rebase_path(generated_script, root_build_dir),
     ]
     args += test_runner_args
   }
 }