[Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard.

[Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard.

This cl fixes urls in dashboard and result page. And new duplicated culprits will not be saved(didn't fix old data).

BUG=607218, 607406
Committed: https://chromium.googlesource.com/infra/infra/+/1f859fc5b3fa11d8e6e7e3fe458d6e7062dfa500

[chanli, 2016-04-28 21:51:57]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-04-28 21:51:57]

ptal

[stgao, 2016-04-28 22:21:47]

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/templates/...
File appengine/findit/templates/build_failure.html (right):

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/templates/...
appengine/findit/templates/build_failure.html:247: var review_url =
tryJobCulprit.url || tryJobCulprit.review_url || findit.defaultGitBaseUrl +
tryJobCulprit.revision;
Use ... || ... || (findit.defaultGitBaseUrl + tryJobCulprit.revision) instead.

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/templates/...
appengine/findit/templates/build_failure.html:247: var review_url =
tryJobCulprit.url || tryJobCulprit.review_url || findit.defaultGitBaseUrl +
tryJobCulprit.revision;
We'd better use review url if it is available.

Same for all other files in this CL.

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/identify_try_job_culprit_pipeline.py (right):

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/identify_try_job_culprit_pipeline.py:78: 'url':
results.get('url'),
Do we use code review url instead git log url for try-job result as we do for
heuristic result? Or heuristic result includes both of them?

[chanli, 2016-04-28 22:37:34]

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/templates/...
File appengine/findit/templates/build_failure.html (right):

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/templates/...
appengine/findit/templates/build_failure.html:247: var review_url =
tryJobCulprit.url || tryJobCulprit.review_url || findit.defaultGitBaseUrl +
tryJobCulprit.revision;
On 2016/04/28 22:21:46, stgao wrote:
> Use ... || ... || (findit.defaultGitBaseUrl + tryJobCulprit.revision) instead.

Done.

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/templates/...
appengine/findit/templates/build_failure.html:247: var review_url =
tryJobCulprit.url || tryJobCulprit.review_url || findit.defaultGitBaseUrl +
tryJobCulprit.revision;
On 2016/04/28 22:21:46, stgao wrote:
> We'd better use review url if it is available.
> 
> Same for all other files in this CL.

As we discussed offline, both tryJobCulprit.url and tryJobCulprit.review_url are
referring the same value(keep tryJobCulprit.review_url for old data)

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/identify_try_job_culprit_pipeline.py (right):

https://codereview.chromium.org/1924173003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/identify_try_job_culprit_pipeline.py:78: 'url':
results.get('url'),
On 2016/04/28 22:21:46, stgao wrote:
> Do we use code review url instead git log url for try-job result as we do for
> heuristic result? Or heuristic result includes both of them?

We are using code_review_url for try jobs as well.

[stgao, 2016-04-28 23:26:16]

lgtm

[chanli, 2016-04-28 23:33:48]

The CQ bit was checked by chanli@chromium.org

[commit-bot: I haz the power, 2016-04-28 23:33:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924173003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924173003/20001

[commit-bot: I haz the power, 2016-04-28 23:39:17]

Description was changed from

==========
[Findit] Fix urls in dashboard and result page and prevent duplicated culprits
in dashboard.

This cl fixes urls in dashboard and result page. And new duplicated culprits
will not be saved(didn't fix old data).

BUG=607218, 607406
==========

to

==========
[Findit] Fix urls in dashboard and result page and prevent duplicated culprits
in dashboard.

This cl fixes urls in dashboard and result page. And new duplicated culprits
will not be saved(didn't fix old data).

BUG=607218, 607406

Committed:
https://chromium.googlesource.com/infra/infra/+/1f859fc5b3fa11d8e6e7e3fe458d6...
==========

[commit-bot: I haz the power, 2016-04-28 23:39:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/1f859fc5b3fa11d8e6e7e3fe458d6...