appengine/findit/templates/waterfall/compile_failure.html - Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/templates/waterfall/compile_failure.html

Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/templates/list_analyses.html ('k') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/templates/waterfall/compile_failure.html

diff --git a/appengine/findit/templates/waterfall/compile_failure.html b/appengine/findit/templates/waterfall/compile_failure.html

index 83c4ee4bb20c6149efe9999d760864d674c37eac..1261a815bc3a9839de40d7cab630313a990e17b9 100644

--- a/appengine/findit/templates/waterfall/compile_failure.html

+++ b/appengine/findit/templates/waterfall/compile_failure.html

@@ -216,7 +216,7 @@

{% if try_job.failed %}

<span class="error">Try job ran into error!</span>

{% elif try_job.culprit %}

- Culprit: {{try_job.culprit.repo_name or 'chromium'}} <a href="{{try_job.culprit.review_url}}">{{try_job.culprit.commit_position or try_job.culprit.revision}}</a>

+ Culprit: {{try_job.culprit.repo_name or 'chromium'}} <a href="{{try_job.culprit.url or try_job.culprit.review_url}}">{{try_job.culprit.commit_position or try_job.culprit.revision}}</a>

{% else %}

<div>No culprit found!</div>

{% endif%}

« no previous file with comments | « appengine/findit/templates/list_analyses.html ('k') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('j') | no next file with comments »