[Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard.

appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from testing_utils import testing
 
 from common.git_repository import GitRepository
 from model import analysis_status
 from model import result_status
 from model.wf_analysis import WfAnalysis
@@ skipping 84 matching lines @@
     # Heuristic analysis provided no results, but the try job found a culprit.
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.result_status = result_status.NOT_FOUND_UNTRIAGED
     analysis.put()
 
     result = {
         'culprit': {
             'compile': {
                 'revision': 'rev1',
                 'commit_position': '1',
-                'review_url': 'url_1',
+                'url': 'url_1',
                 'repo_name': 'chromium'
             }
         }
     }
 
     status = identify_try_job_culprit_pipeline._GetResultAnalysisStatus(
         analysis, result)
 
     self.assertEqual(status, result_status.FOUND_UNTRIAGED)
 
   def testGetResultAnalysisStatusWithTryJobCulpritNotFoundCorrect(self):
     # Heuristic analysis found no results, which was correct. In this case, the
     # try job result is actually a false positive.
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.result_status = result_status.NOT_FOUND_CORRECT
     analysis.put()
 
     result = {
         'culprit': {
             'compile': {
                 'revision': 'rev1',
                 'commit_position': '1',
-                'review_url': 'url_1',
+                'url': 'url_1',
                 'repo_name': 'chromium'
             }
         }
     }
 
     status = identify_try_job_culprit_pipeline._GetResultAnalysisStatus(
         analysis, result)
 
     self.assertEqual(status, result_status.FOUND_UNTRIAGED)
 
   def testGetResultanalysisStatusWithTryJobCulpritNotFoundIncorrect(self):
     # Heuristic analysis found no results and was triaged to incorrect before a
     # try job result was found. In this case the try job result should override
     # the heuristic result.
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.result_status = result_status.NOT_FOUND_INCORRECT
     analysis.put()
 
     result = {
         'culprit': {
             'compile': {
                 'revision': 'rev1',
                 'commit_position': '1',
-                'review_url': 'url_1',
+                'url': 'url_1',
                 'repo_name': 'chromium'
             }
         }
     }
 
     status = identify_try_job_culprit_pipeline._GetResultAnalysisStatus(
         analysis, result)
 
     self.assertEqual(status, result_status.FOUND_UNTRIAGED)
 
   def testGetResultanalysisStatusWithTryJobCulpritNoHeuristicResult(self):
     # In this case, the try job found a result before the heuristic result is
     # available. This case should generally never happen, as heuristic analysis
     # is usually much faster than try jobs.
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.put()
 
     result = {
         'culprit': {
             'compile': {
                 'revision': 'rev1',
                 'commit_position': '1',
-                'review_url': 'url_1',
+                'url': 'url_1',
                 'repo_name': 'chromium'
             }
         }
     }
 
     status = identify_try_job_culprit_pipeline._GetResultAnalysisStatus(
         analysis, result)
 
     self.assertEqual(status, result_status.FOUND_UNTRIAGED)
 
@@ skipping 14 matching lines @@
     # result should not overwrite it.
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.result_status = result_status.FOUND_CORRECT
     analysis.put()
 
     result = {
         'culprit': {
             'compile': {
                 'revision': 'rev1',
                 'commit_position': '1',
-                'review_url': 'url_1',
+                'url': 'url_1',
                 'repo_name': 'chromium'
             }
         }
     }
 
     status = identify_try_job_culprit_pipeline._GetResultAnalysisStatus(
         analysis, result)
     self.assertEqual(status, result_status.FOUND_CORRECT)
 
   def testGetResultanalysisStatusWithNoCulpritTriagedCorrect(self):
@@ skipping 21 matching lines @@
     result = {}
 
     status = identify_try_job_culprit_pipeline._GetResultAnalysisStatus(
         analysis, result)
     self.assertEqual(status, result_status.NOT_FOUND_INCORRECT)
 
   def testGetSuspectedCLsForCompileTryJob(self):
     heuristic_suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
 
     compile_suspected_cl = {
         'revision': 'rev2',
         'commit_position': '2',
-        'review_url': 'url_2',
+        'url': 'url_2',
         'repo_name': 'chromium'
     }
 
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.suspected_cls = [heuristic_suspected_cl]
     analysis.put()
 
     result = {
         'culprit': {
             'compile': compile_suspected_cl
         }
     }
 
     self.assertEqual(
         identify_try_job_culprit_pipeline._GetSuspectedCLs(analysis, result),
         [heuristic_suspected_cl, compile_suspected_cl])
 
   def testGetSuspectedCLsForTestTryJobAndHeuristicResultsSame(self):
     suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
 
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.suspected_cls = [suspected_cl]
     analysis.put()
 
     result = {
         'culprit': {
             'compile': suspected_cl
         }
     }
 
     self.assertEqual(
         identify_try_job_culprit_pipeline._GetSuspectedCLs(analysis, result),
         [suspected_cl])
 
   def testGetSuspectedCLsForTestTryJob(self):
     suspected_cl1 = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
     suspected_cl2 = {
         'revision': 'rev2',
         'commit_position': '2',
-        'review_url': 'url_2',
+        'url': 'url_2',
         'repo_name': 'chromium'
     }
     suspected_cl3 = {
         'revision': 'rev3',
         'commit_position': '3',
-        'review_url': 'url_3',
+        'url': 'url_3',
         'repo_name': 'chromium'
     }
 
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.suspected_cls = []
     analysis.put()
 
     result = {
         'culprit': {
             'a_test': {
                 'tests': {
                     'a_test1': suspected_cl1,
                     'a_test2': suspected_cl1
                 }
             },
             'b_test': {
                 'tests': {
                     'b_test1': suspected_cl2
                 }
             },
             'c_test': {
                 'revision': 'rev3',
                 'commit_position': '3',
-                'review_url': 'url_3',
+                'url': 'url_3',
                 'repo_name': 'chromium',
                 'tests': {}
             }
         }
     }
 
     self.assertEqual(
         identify_try_job_culprit_pipeline._GetSuspectedCLs(analysis, result),
         [suspected_cl3, suspected_cl2, suspected_cl1])
 
   def testGetSuspectedCLsForTestTryJobWithHeuristicResult(self):
     suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
 
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.suspected_cls = [suspected_cl]
     analysis.put()
 
     result = {
         'culprit': {
             'a_test': {
                 'revision': 'rev1',
                 'commit_position': '1',
-                'review_url': 'url_1',
+                'url': 'url_1',
                 'repo_name': 'chromium',
                 'tests': {}
             }
         }
     }
-
     self.assertEqual(
         identify_try_job_culprit_pipeline._GetSuspectedCLs(analysis, result),
         [suspected_cl])
 
   def testIdentifyCulpritForCompileTryJobNoCulprit(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
@@ skipping 53 matching lines @@
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1'],
         TryJobType.COMPILE, '1', compile_result)
 
     expected_culprit = 'rev2'
     expected_suspected_cl = {
         'revision': 'rev2',
         'commit_position': '2',
-        'review_url': 'url_2',
+        'url': 'url_2',
         'repo_name': 'chromium'
     }
     expected_compile_result = {
         'report': {
             'result': {
                 'rev1': 'passed',
                 'rev2': 'failed'
             }
         },
         'try_job_id': try_job_id,
@@ skipping 79 matching lines @@
 
   def testIdentifyCulpritForTestTryJobNoTryJobResultWithHeuristicResult(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
     suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
 
     WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
 
     # Heuristic analysis already provided some results.
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
@@ skipping 172 matching lines @@
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
         TryJobType.TEST, '1', test_result)
 
     a_test1_suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
     a_test2_suspected_cl = {
         'revision': 'rev2',
         'commit_position': '2',
-        'review_url': 'url_2',
+        'url': 'url_2',
         'repo_name': 'chromium'
     }
 
     b_test1_suspected_cl = a_test1_suspected_cl
 
     expected_test_result = {
         'report': {
             'result': {
                 'rev1': {
                     'a_test': {
@@ skipping 39 matching lines @@
                 }
             },
             'b_test': {
                 'tests': {
                     'b_test1': b_test1_suspected_cl
                 }
             },
             'c_test': {
                 'revision': 'rev2',
                 'commit_position': '2',
-                'review_url': 'url_2',
+                'url': 'url_2',
                 'repo_name': 'chromium',
                 'tests': {}
             }
         }
     }
 
     self.assertEqual(expected_test_result['culprit'], culprit)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
     self.assertEqual(expected_test_result, try_job.test_results[-1])
@@ skipping 18 matching lines @@
 
   def testAnalysisIsUpdatedOnlyIfStatusOrSuspectedCLsChanged(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
     suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
-        'review_url': 'url_1',
+        'url': 'url_1',
         'repo_name': 'chromium'
     }
 
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.suspected_cls = [suspected_cl]
     analysis.result_status = result_status.FOUND_UNTRIAGED
     analysis.put()
     version = analysis.version
     compile_result = {
         'report': {
@@ skipping 20 matching lines @@
     try_job.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     pipeline.run(master_name, builder_name, build_number, ['rev1'],
                  TryJobType.COMPILE, '1', compile_result)
 
     self.assertEqual(analysis.result_status,
                      result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls, [suspected_cl])
     self.assertEqual(version, analysis.version)  # No update to analysis.