appengine/findit/templates/build_failure.html - Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard.

Side by Side Diff: appengine/findit/templates/build_failure.html

Issue 1924173003: [Findit] Fix urls in dashboard and result page and prevent duplicated culprits in dashboard. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <head>	2 <head>

3 <title>Build Failure</title>	3 <title>Build Failure</title>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="stylesheet" href="/common.css">	5 <link rel="stylesheet" href="/common.css">

6 <style>	6 <style>

7 .running {	7 .running {

8 color: #666666;	8 color: #666666;

9 background-color: #fffc6c;	9 background-color: #fffc6c;

10 border-color: #c5c56d;	10 border-color: #c5c56d;

(...skipping 226 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
237 tableString += '<tr>';	237 tableString += '<tr>';

238 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1;	238 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1;

239	239

240 tableString += generateCommonCellsForAllCategories(step_name, 'determi ned', index, result.tests, result.first_failure, result.last_pass, rowspan);	240 tableString += generateCommonCellsForAllCategories(step_name, 'determi ned', index, result.tests, result.first_failure, result.last_pass, rowspan);

241	241

242 var tryJob = result.try_job;	242 var tryJob = result.try_job;

243 var tryJobCulprit = tryJob.culprit;	243 var tryJobCulprit = tryJob.culprit;

244 if (! jQuery.isEmptyObject(tryJobCulprit)) {	244 if (! jQuery.isEmptyObject(tryJobCulprit)) {

245 var build_number = result.try_job.try_job_key.split('/')[2]; // try _job_key would look like: 'master_name/builder_name/build_number'.	245 var build_number = result.try_job.try_job_key.split('/')[2]; // try _job_key would look like: 'master_name/builder_name/build_number'.

246 tableString += '<td rowspan="' + rowspan + '"><a href="' + findit.bu ilderUrl + '/builds/' + build_number + '">' + build_number + '</a></td>';	246 tableString += '<td rowspan="' + rowspan + '"><a href="' + findit.bu ilderUrl + '/builds/' + build_number + '">' + build_number + '</a></td>';

247 var review_url = tryJobCulprit.review_url \|\| findit.defaultGitBaseUr l + 'tryJobCulprit.revision';	247 var review_url = tryJobCulprit.url \|\| tryJobCulprit.review_url \|\| fi ndit.defaultGitBaseUrl + tryJobCulprit.revision;
	stgao 2016/04/28 22:21:46 We'd better use review url if it is available. Sa We'd better use review url if it is available. Same for all other files in this CL. stgao 2016/04/28 22:21:46 Use ... \|\| ... \|\| (findit.defaultGitBaseUrl + tryJ Use ... \|\| ... \|\| (findit.defaultGitBaseUrl + tryJobCulprit.revision) instead. chanli 2016/04/28 22:37:34 As we discussed offline, both tryJobCulprit.url an Show quoted text On 2016/04/28 22:21:46, stgao wrote: > We'd better use review url if it is available. > > Same for all other files in this CL. As we discussed offline, both tryJobCulprit.url and tryJobCulprit.review_url are referring the same value(keep tryJobCulprit.review_url for old data) chanli 2016/04/28 22:37:34 Done. Show quoted text On 2016/04/28 22:21:46, stgao wrote: > Use ... \|\| ... \|\| (findit.defaultGitBaseUrl + tryJobCulprit.revision) instead. Done.
248 tableString += '<td rowspan="' + rowspan + '"><a href="' + review_ur l + '">' + tryJobCulprit.commit_position \|\| tryJobCulprit.revision + '</a></td>' ;	248 tableString += '<td rowspan="' + rowspan + '"><a href="' + review_ur l + '">' + tryJobCulprit.commit_position \|\| tryJobCulprit.revision + '</a></td>' ;

249	249

250 } else {	250 } else {

251 tableString += '<td colspan="2" rowspan="' + rowspan + '">' + findit .tryjobStatusMessageMap[tryJob.status] + '</td>';	251 tableString += '<td colspan="2" rowspan="' + rowspan + '">' + findit .tryjobStatusMessageMap[tryJob.status] + '</td>';

252 }	252 }

253	253

254 tableString += '<td rowspan="' + rowspan + '">';	254 tableString += '<td rowspan="' + rowspan + '">';

255 tableString += '<li>Reliable failure: <a href="' + tryJob.task_url+ '" >' + tryJob.task_id + '</a></li>';	255 tableString += '<li>Reliable failure: <a href="' + tryJob.task_url+ '" >' + tryJob.task_id + '</a></li>';

256 if (tryJob.try_job_url) {	256 if (tryJob.try_job_url) {

257 tableString += '<li>For try job details: <a href="' + tryJob.try_job _url+ '">' + tryJob.try_job_build_number + '</a></li>';	257 tableString += '<li>For try job details: <a href="' + tryJob.try_job _url+ '">' + tryJob.try_job_build_number + '</a></li>';

(...skipping 290 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
548 appearing in the failure log. (eg: file.h was changed and	548 appearing in the failure log. (eg: file.h was changed and

549 file_unittest.cc or file_impl.cc appeared in the log.)</li>	549 file_unittest.cc or file_impl.cc appeared in the log.)</li>

550 <li>1: The CL rolled a dependency within src/DEPS and a file of that	550 <li>1: The CL rolled a dependency within src/DEPS and a file of that

551 dependency appears in the failure log. (eg: third_party/dep	551 dependency appears in the failure log. (eg: third_party/dep

552 was changed in src/DEPS and third_party/dep/f.cpp appeared	552 was changed in src/DEPS and third_party/dep/f.cpp appeared

553 in the log.)</li>	553 in the log.)</li>

554 </ul>	554 </ul>

555 (More rules will be added when implemented.)	555 (More rules will be added when implemented.)

556 </div>	556 </div>

557 </body>	557 </body>

OLD	NEW

« no previous file with comments | « no previous file | appengine/findit/templates/list_analyses.html » ('j') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('J')