Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1923283002: Password internals page logs names of filled elements (Closed)

Created:
4 years, 7 months ago by vabr (Chromium)
Modified:
4 years, 7 months ago
Reviewers:
dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Password internals page logs names of filled elements This adds a method to the renderer version of the password mangaer internals logger to log form element names, and applies it to some code in PasswordAutofillAgent. The CL also fixes include guards in renderer_save_password_progress_logger.h R=dvadym@chromium.org BUG=606736 Committed: https://crrev.com/48c8ef0f7d7dccfbf818c289c771ca2ddaece9aa Cr-Commit-Position: refs/heads/master@{#390059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger.h View 4 chunks +10 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923283002/1
4 years, 7 months ago (2016-04-27 12:35:50 UTC) #2
vabr (Chromium)
Hi Vadym, This is the promised follow-up, PTAL. Thanks! Vaclav
4 years, 7 months ago (2016-04-27 12:36:12 UTC) #3
dvadym
LGTM, thanks!
4 years, 7 months ago (2016-04-27 13:08:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923283002/1
4 years, 7 months ago (2016-04-27 13:10:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 13:38:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 13:39:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c8ef0f7d7dccfbf818c289c771ca2ddaece9aa
Cr-Commit-Position: refs/heads/master@{#390059}

Powered by Google App Engine
This is Rietveld 408576698