Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger.cc

Issue 1923283002: Password internals page logs names of filled elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/renderer_save_password_progress_logger.cc
diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger.cc b/components/autofill/content/renderer/renderer_save_password_progress_logger.cc
index 43ce6736ac88699001a4c3a7a221d742006061a7..413b5f5d56f7d3eedcf3e9c51e847445d6a8db65 100644
--- a/components/autofill/content/renderer/renderer_save_password_progress_logger.cc
+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger.cc
@@ -4,8 +4,11 @@
#include "components/autofill/content/renderer/renderer_save_password_progress_logger.h"
+#include "base/strings/string16.h"
+#include "base/values.h"
#include "components/autofill/content/common/autofill_messages.h"
#include "ipc/ipc_sender.h"
+#include "third_party/WebKit/public/web/WebFormControlElement.h"
namespace autofill {
@@ -23,4 +26,11 @@ void RendererSavePasswordProgressLogger::SendLog(const std::string& log) {
new AutofillHostMsg_RecordSavePasswordProgress(routing_id_, log));
}
+void RendererSavePasswordProgressLogger::LogElementName(
+ StringID label,
+ const blink::WebFormControlElement& element) {
+ LogValue(label, base::StringValue(ScrubElementID(
+ base::string16(element.nameForAutofill()))));
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698