Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger.h

Issue 1923283002: Password internals page logs names of filled elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/renderer_save_password_progress_logger.h
diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger.h b/components/autofill/content/renderer/renderer_save_password_progress_logger.h
index dd111b179a1687baaf729f33cf21cc2d9810c82f..bccfd1b0ef5f02fa68433ad5247bb81911e1f96b 100644
--- a/components/autofill/content/renderer/renderer_save_password_progress_logger.h
+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_BROWSER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
-#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_BROWSER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
+#ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
+#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
#include <string>
@@ -12,6 +12,10 @@
class PasswordManagerClient;
+namespace blink {
+class WebFormControlElement;
+}
+
namespace IPC {
class Sender;
}
@@ -28,6 +32,9 @@ class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger {
RendererSavePasswordProgressLogger(IPC::Sender* sender, int routing_id);
~RendererSavePasswordProgressLogger() override;
+ void LogElementName(StringID label,
+ const blink::WebFormControlElement& element);
+
protected:
// SavePasswordProgressLogger:
void SendLog(const std::string& log) override;
@@ -43,4 +50,4 @@ class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger {
} // namespace autofill
-#endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_BROWSER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
+#endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_SAVE_PASSWORD_PROGRESS_LOGGER_H_

Powered by Google App Engine
This is Rietveld 408576698