Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4808)

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1923283002: Password internals page logs names of filled elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/renderer/renderer_save_password_progress_logger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/save_password_progress_logger.cc
diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc
index de2ca456f8b0f11ea48c0ed3cc73eeb91c48f3d0..ddc55f42893ba718cda0ed9f5cd4e347f347ce6a 100644
--- a/components/autofill/core/common/save_password_progress_logger.cc
+++ b/components/autofill/core/common/save_password_progress_logger.cc
@@ -378,9 +378,9 @@ std::string SavePasswordProgressLogger::GetStringFromID(
case SavePasswordProgressLogger::STRING_MATCH_IN_ADDITIONAL:
return "Match found in additional logins";
case SavePasswordProgressLogger::STRING_USERNAME_FILLED:
- return "Username was filled";
+ return "Filled username element named";
case SavePasswordProgressLogger::STRING_PASSWORD_FILLED:
- return "Password was filled";
+ return "Filled password element named";
case SavePasswordProgressLogger::STRING_INVALID:
return "INVALID";
// Intentionally no default: clause here -- all IDs need to get covered.
« no previous file with comments | « components/autofill/content/renderer/renderer_save_password_progress_logger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698