Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1921973002: Convert //components/[a-e]* from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, Eran Messeri, estade+watch_chromium.org, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, msw+watch_chromium.org, pfeldman, rouslan+autofill_chromium.org, rouslan+bubble_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/[a-e]* from scoped_ptr to std::unique_ptr BUG=554298 R=danakj@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/a0ee5fb8a4dbf546b8da197a055dd3997f3dc475 Cr-Commit-Position: refs/heads/master@{#389675}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -332 lines) Patch
M components/app_modal/javascript_dialog_manager.h View 3 chunks +6 lines, -5 lines 0 comments Download
M components/app_modal/javascript_dialog_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/app_modal/views/javascript_app_modal_dialog_views.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_bootstrap.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_bootstrap.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_service.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/arc_bridge_service_impl.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/arc_bridge_service_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M components/arc/arc_service_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/arc/arc_service_manager.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/ime/arc_ime_service.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/arc/ime/arc_ime_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/ime/arc_ime_service_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/arc/standalone/arc_standalone_bridge_runner.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/arc/standalone/service_helper_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/audio_modem/audio_player_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/audio_modem/audio_player_unittest.cc View 1 5 chunks +6 lines, -4 lines 0 comments Download
M components/audio_modem/audio_recorder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/audio_modem/audio_recorder_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/audio_modem/audio_recorder_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/audio_modem/audio_recorder_unittest.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M components/audio_modem/modem_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/audio_modem/modem_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/audio_modem/public/modem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/audio_modem/test/random_samples.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.h View 4 chunks +5 lines, -4 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/window_hang_monitor_win_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/bubble/bubble_controller.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/bubble/bubble_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bubble/bubble_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bubble/bubble_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/bubble/bubble_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/bubble/bubble_manager_mocks.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M components/bubble/bubble_manager_mocks.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M components/bubble/bubble_manager_unittest.cc View 1 13 chunks +17 lines, -15 lines 0 comments Download
M components/captive_portal/captive_portal_detector.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/captive_portal/captive_portal_detector_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/certificate_reporting/error_report.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/certificate_reporting/error_reporter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/certificate_reporting/error_reporter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M components/certificate_reporting/error_reporter_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/certificate_transparency/log_proof_fetcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/certificate_transparency/log_proof_fetcher.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download
M components/certificate_transparency/log_proof_fetcher_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M components/client_update_protocol/ecdsa.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/client_update_protocol/ecdsa.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/client_update_protocol/ecdsa_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/cloud_devices/common/cloud_device_description.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/cloud_devices/common/cloud_device_description.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/cloud_devices/common/printer_description_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/component_updater/component_updater_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/component_updater/component_updater_service.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/component_updater/component_updater_service_internal.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/component_updater/component_updater_service_unittest.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download
M components/component_updater/default_component_installer.h View 4 chunks +10 lines, -8 lines 0 comments Download
M components/component_updater/default_component_installer.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M components/constrained_window/constrained_window_views.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/constrained_window/constrained_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/constrained_window/constrained_window_views_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/crx_file/crx_file.h View 3 chunks +8 lines, -8 lines 0 comments Download
M components/crx_file/crx_file.cc View 1 4 chunks +12 lines, -12 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M components/data_use_measurement/content/data_use_measurement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_use_measurement/content/data_use_measurement_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/device_event_log/device_event_log_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.h View 6 chunks +8 lines, -8 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 1 2 10 chunks +22 lines, -22 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler_unittest.cc View 1 7 chunks +23 lines, -17 lines 0 comments Download
M components/error_page/common/error_page_params.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/error_page/common/localized_error.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/error_page/common/localized_error.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.h View 5 chunks +6 lines, -6 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.cc View 1 10 chunks +18 lines, -21 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core_unittest.cc View 1 7 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
Same deal. +danakj for sanity review, +jochen for owners review (will TBR)
4 years, 8 months ago (2016-04-26 00:40:27 UTC) #1
danakj
LGTM https://codereview.chromium.org/1921973002/diff/20001/components/component_updater/default_component_installer.cc File components/component_updater/default_component_installer.cc (right): https://codereview.chromium.org/1921973002/diff/20001/components/component_updater/default_component_installer.cc#newcode122 components/component_updater/default_component_installer.cc:122: // so we can avoid this DeepCopy. fix ...
4 years, 8 months ago (2016-04-26 01:27:54 UTC) #2
dcheng
https://codereview.chromium.org/1921973002/diff/20001/components/component_updater/default_component_installer.cc File components/component_updater/default_component_installer.cc (right): https://codereview.chromium.org/1921973002/diff/20001/components/component_updater/default_component_installer.cc#newcode122 components/component_updater/default_component_installer.cc:122: // so we can avoid this DeepCopy. On 2016/04/26 ...
4 years, 8 months ago (2016-04-26 01:35:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921973002/40001
4 years, 8 months ago (2016-04-26 01:35:28 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 02:47:08 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 02:48:56 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0ee5fb8a4dbf546b8da197a055dd3997f3dc475
Cr-Commit-Position: refs/heads/master@{#389675}

Powered by Google App Engine
This is Rietveld 408576698