components/cloud_devices/common/printer_description_unittest.cc - Issue 1921973002: Convert //components/[a-e]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cloud_devices/common/printer_description_unittest.cc

Issue 1921973002: Convert //components/[a-e]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cloud_devices/common/cloud_device_description.cc ('k') | components/component_updater/component_updater_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cloud_devices/common/printer_description_unittest.cc

diff --git a/components/cloud_devices/common/printer_description_unittest.cc b/components/cloud_devices/common/printer_description_unittest.cc

index 72d0ee469918fba67caad25388b537a3cd3928f7..f190e17d5b831ad88cd658da82505e4e8cb5c862 100644

--- a/components/cloud_devices/common/printer_description_unittest.cc

+++ b/components/cloud_devices/common/printer_description_unittest.cc

@@ -4,6 +4,8 @@

#include "components/cloud_devices/common/printer_description.h"

+#include <memory>

#include "base/json/json_reader.h"

#include "base/json/json_writer.h"

#include "base/strings/string_util.h"

@@ -20,7 +22,7 @@ namespace printer {

std::string NormalizeJson(const std::string& json) {

std::string result = json;

base::ReplaceChars(result, "'", "\"", &result);

- scoped_ptr<base::Value> value = base::JSONReader::Read(result);

+ std::unique_ptr<base::Value> value = base::JSONReader::Read(result);

DCHECK(value);

base::JSONWriter::Write(*value, &result);

return result;