Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1921883002: Removes WindowState::aura_window() (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, dcheng, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes WindowState::aura_window() And minimizes dependencies in a couple of other places. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b Cr-Commit-Position: refs/heads/master@{#389698}

Patch Set 1 #

Patch Set 2 : nuke deps #

Total comments: 2

Patch Set 3 : GetAuraWindow #

Patch Set 4 : fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -81 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/common/root_window_finder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/common/window_state_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window_tracker.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/default_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/default_state.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 3 chunks +1 line, -5 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/lock_window_state.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 12 chunks +22 lines, -25 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_resizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_state.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/wm/window_state.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sky
4 years, 7 months ago (2016-04-25 21:24:49 UTC) #1
James Cook
LGTM https://codereview.chromium.org/1921883002/diff/20001/ash/frame/custom_frame_view_ash.cc File ash/frame/custom_frame_view_ash.cc (right): https://codereview.chromium.org/1921883002/diff/20001/ash/frame/custom_frame_view_ash.cc#newcode98 ash/frame/custom_frame_view_ash.cc:98: ash::wm::WmWindowAura::GetAuraWindow(window_state_->window()) optional: Add a utility function aura::Window* GetAuraWindow() ...
4 years, 7 months ago (2016-04-26 00:46:44 UTC) #2
sky
https://codereview.chromium.org/1921883002/diff/20001/ash/frame/custom_frame_view_ash.cc File ash/frame/custom_frame_view_ash.cc (right): https://codereview.chromium.org/1921883002/diff/20001/ash/frame/custom_frame_view_ash.cc#newcode98 ash/frame/custom_frame_view_ash.cc:98: ash::wm::WmWindowAura::GetAuraWindow(window_state_->window()) On 2016/04/26 00:46:43, James Cook wrote: > optional: ...
4 years, 7 months ago (2016-04-26 02:57:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921883002/40001
4 years, 7 months ago (2016-04-26 02:58:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/211216)
4 years, 7 months ago (2016-04-26 03:32:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921883002/60001
4 years, 7 months ago (2016-04-26 04:02:43 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-26 04:48:11 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 04:50:09 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b
Cr-Commit-Position: refs/heads/master@{#389698}

Powered by Google App Engine
This is Rietveld 408576698