Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1921833002: Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1 (Closed)

Created:
4 years, 8 months ago by scottmg
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1 f64ef73d8bba Update project status docs for Windows 74c3eb8d0f3e doc: Fix links with plus signs in rendered output 71f6724239bf Disable end-to-end test of extra memory range removal 12536e06e526 Replace base/template_util.h stuff with C++11 type_traits 1fe622550d87 win: Check that UseHandler() has been called in DumpAndCrash() 0d4438b2a547 win: Don't add zero-sized memory ranges to dump 96dba6713abf Make VS2015 build work dbfcb5d03211 win: Cap indirect memory gathering 6a6a0c27ed0c win: Support dumping another process by causing it to crash b6089da2bfab Roll mini_chromium to 783fdf3ccc1c cf452d9a8608 Fix Mac after dbfcb5d03 a4649789a52f Roll mini_chromium to 0a9dc1c4feea d6d726a0eb83 Update to use base/bit_cast.h to follow to follow https://codereview.chromium.org/399313006 a02ba240062a Convert from scoped_ptr to std::unique_ptr 00d458adaf38 Roll mini_chromium to 964ee49aa24e BUG=crashpad:104, crashpad:103, crashpad:98 Committed: https://crrev.com/9e3bcaa124626a0e2f1781fbb8c4a390930fc894 Cr-Commit-Position: refs/heads/master@{#389578}

Patch Set 1 #

Patch Set 2 : win fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+929 lines, -112 lines) Patch
M build/secondary/third_party/crashpad/crashpad/client/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/crash/content/app/crashpad_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/README.chromium View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client.h View 2 chunks +37 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_win.cc View 3 chunks +266 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_info.h View 2 chunks +12 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_info.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/doc/status.ad View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/handler/win/crash_other_program.cc View 1 chunk +120 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crashy_test_program.cc View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/crashpad/crashpad/handler/win/hanging_program.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A + third_party/crashpad/crashpad/handler/win/loader_lock_dll.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_string_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/capture_memory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/crashpad_info_client_options.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types/crashpad_info.proctype View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/capture_memory_delegate_win.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/capture_memory_delegate_win.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/end_to_end_test.py View 7 chunks +49 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h View 4 chunks +18 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.cc View 6 chunks +100 lines, -32 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/thread_snapshot_win.h View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/thread_snapshot_win.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/nt_internals.h View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/nt_internals.cc View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
scottmg
4 years, 8 months ago (2016-04-25 21:50:29 UTC) #4
Robert Sesek
LGTM
4 years, 8 months ago (2016-04-25 21:53:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921833002/20001
4 years, 8 months ago (2016-04-25 22:03:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 22:11:32 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 22:13:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e3bcaa124626a0e2f1781fbb8c4a390930fc894
Cr-Commit-Position: refs/heads/master@{#389578}

Powered by Google App Engine
This is Rietveld 408576698