third_party/crashpad/crashpad/snapshot/capture_memory.cc - Issue 1921833002: Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/capture_memory.cc

Issue 1921833002: Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: win fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer_test.cc ('k') | third_party/crashpad/crashpad/snapshot/crashpad_info_client_options.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/capture_memory.cc

diff --git a/third_party/crashpad/crashpad/snapshot/capture_memory.cc b/third_party/crashpad/crashpad/snapshot/capture_memory.cc

index 0c30311524209dfe89fba005b9957eceda335139..eba6729c31db1e667f8c70f459feed4a46a38a89 100644

--- a/third_party/crashpad/crashpad/snapshot/capture_memory.cc

+++ b/third_party/crashpad/crashpad/snapshot/capture_memory.cc

@@ -38,9 +38,9 @@ void MaybeCaptureMemoryAround(CaptureMemory::Delegate* delegate,

if (address > max_address - non_address_offset)

return;

- const uint64_t kRegisterByteOffset = 256;

+ const uint64_t kRegisterByteOffset = 128;

const uint64_t target = address - kRegisterByteOffset;

- const uint64_t size = 1024;

+ const uint64_t size = 512;

static_assert(kRegisterByteOffset <= size / 2,

"negative offset too large");

auto ranges =