third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc - Issue 1921833002: Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc

Issue 1921833002: Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: win fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_string_writer.cc ('k') | third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc

index 06982a4aad253c3520a02001b00445bc11e2c1a7..ea498e966efdca6a3eed62da46e28f200712fd08 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc

@@ -221,9 +221,11 @@ TEST(MinidumpThreadWriter, OneThread_AMD64_Stack) {

new TestMinidumpMemoryWriter(kMemoryBase, kMemorySize, kMemoryValue));

thread_writer->SetStack(std::move(memory_writer));

- MSVC_SUPPRESS_WARNING(4316); // Object allocated on heap may not be aligned.

+ // Object allocated on heap may not be aligned.

+ MSVC_PUSH_DISABLE_WARNING(4316);

auto context_amd64_writer =

base::WrapUnique(new MinidumpContextAMD64Writer());

+ MSVC_POP_WARNING(); // C4316.

InitializeMinidumpContextAMD64(context_amd64_writer->context(), kSeed);

thread_writer->SetContext(std::move(context_amd64_writer));