Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc

Issue 1921833002: Update Crashpad to 00d458adaf3868999eeab5341fce5bedb81d17a1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc
diff --git a/third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc b/third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc
index 50ba63105efe77668896d01d9886324f36f1c97a..6f32dd41e4a162b883411f26bc603466150336d5 100644
--- a/third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc
+++ b/third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc
@@ -61,7 +61,8 @@ class ScopedUnsetCrashpadInfoOptions {
~ScopedUnsetCrashpadInfoOptions() {
crashpad_info_->set_crashpad_handler_behavior(TriState::kUnset);
crashpad_info_->set_system_crash_reporter_forwarding(TriState::kUnset);
- crashpad_info_->set_gather_indirectly_referenced_memory(TriState::kUnset);
+ crashpad_info_->set_gather_indirectly_referenced_memory(TriState::kUnset,
+ 0);
}
private:
@@ -94,6 +95,7 @@ TEST(CrashpadInfoClientOptions, OneModule) {
EXPECT_EQ(TriState::kUnset, options.crashpad_handler_behavior);
EXPECT_EQ(TriState::kUnset, options.system_crash_reporter_forwarding);
EXPECT_EQ(TriState::kUnset, options.gather_indirectly_referenced_memory);
+ EXPECT_EQ(0u, options.indirectly_referenced_memory_cap);
CrashpadInfo* crashpad_info = CrashpadInfo::GetCrashpadInfo();
ASSERT_TRUE(crashpad_info);
@@ -107,6 +109,7 @@ TEST(CrashpadInfoClientOptions, OneModule) {
EXPECT_EQ(TriState::kEnabled, options.crashpad_handler_behavior);
EXPECT_EQ(TriState::kUnset, options.system_crash_reporter_forwarding);
EXPECT_EQ(TriState::kUnset, options.gather_indirectly_referenced_memory);
+ EXPECT_EQ(0u, options.indirectly_referenced_memory_cap);
}
{
@@ -118,17 +121,20 @@ TEST(CrashpadInfoClientOptions, OneModule) {
EXPECT_EQ(TriState::kUnset, options.crashpad_handler_behavior);
EXPECT_EQ(TriState::kDisabled, options.system_crash_reporter_forwarding);
EXPECT_EQ(TriState::kUnset, options.gather_indirectly_referenced_memory);
+ EXPECT_EQ(0u, options.indirectly_referenced_memory_cap);
}
{
ScopedUnsetCrashpadInfoOptions unset(crashpad_info);
- crashpad_info->set_gather_indirectly_referenced_memory(TriState::kEnabled);
+ crashpad_info->set_gather_indirectly_referenced_memory(TriState::kEnabled,
+ 1234);
options = SelfProcessSnapshotAndGetCrashpadOptions();
EXPECT_EQ(TriState::kUnset, options.crashpad_handler_behavior);
EXPECT_EQ(TriState::kUnset, options.system_crash_reporter_forwarding);
EXPECT_EQ(TriState::kEnabled, options.gather_indirectly_referenced_memory);
+ EXPECT_EQ(1234u, options.indirectly_referenced_memory_cap);
}
}

Powered by Google App Engine
This is Rietveld 408576698