[Offline Pages] Remove obsolete synchronous API methods.

[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526
Committed: https://crrev.com/42b8cf539dc33d653594e6d5ce1567a5b48f6efa
Cr-Commit-Position: refs/heads/master@{#389900}

[dewittj, 2016-04-25 22:33:31]

Description was changed from

==========
[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526
==========

to

==========
[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526
==========

[dewittj, 2016-04-25 22:33:31]

dewittj@chromium.org changed reviewers:
+ jianli@chromium.org

[dewittj, 2016-04-25 22:33:42]

jianli: ptal

[jianli, 2016-04-25 22:41:31]

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:319: const
std::vector<OfflinePageItem> OfflinePageModel::GetPagesToCleanUp() const {
Do we also need to remove this?

[dewittj, 2016-04-25 22:56:55]

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:319: const
std::vector<OfflinePageItem> OfflinePageModel::GetPagesToCleanUp() const {
On 2016/04/25 22:41:31, jianli wrote:
> Do we also need to remove this?

I have been leaving things like this and markpageaccessed since it seems likely
we will need the functionality for the automatic features we are shipping soon. 
Do you prefer removing it now?

[fgorski, 2016-04-26 03:20:49]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-04-26 03:20:50]

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:319: const
std::vector<OfflinePageItem> OfflinePageModel::GetPagesToCleanUp() const {
On 2016/04/25 22:56:55, dewittj wrote:
> On 2016/04/25 22:41:31, jianli wrote:
> > Do we also need to remove this?
> 
> I have been leaving things like this and markpageaccessed since it seems
likely
> we will need the functionality for the automatic features we are shipping
soon. 
> Do you prefer removing it now?

Put a TODO(fgorski): This needs an update as part of expiration policy work.

[dewittj, 2016-04-26 16:24:01]

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1921563005/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:319: const
std::vector<OfflinePageItem> OfflinePageModel::GetPagesToCleanUp() const {
On 2016/04/26 03:20:50, fgorski wrote:
> On 2016/04/25 22:56:55, dewittj wrote:
> > On 2016/04/25 22:41:31, jianli wrote:
> > > Do we also need to remove this?
> > 
> > I have been leaving things like this and markpageaccessed since it seems
> likely
> > we will need the functionality for the automatic features we are shipping
> soon. 
> > Do you prefer removing it now?
> 
> Put a TODO(fgorski): This needs an update as part of expiration policy work.

Done.

[jianli, 2016-04-26 21:06:08]

lgtm

[dewittj, 2016-04-26 21:07:34]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921563005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921563005/20001

[commit-bot: I haz the power, 2016-04-26 21:43:57]

Description was changed from

==========
[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526
==========

to

==========
[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526
==========

[commit-bot: I haz the power, 2016-04-26 21:43:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 21:45:04]

Description was changed from

==========
[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526
==========

to

==========
[Offline Pages] Remove obsolete synchronous API methods.

These became unused due to recent changes to the Bookmarks integration.

BUG=589526

Committed: https://crrev.com/42b8cf539dc33d653594e6d5ce1567a5b48f6efa
Cr-Commit-Position: refs/heads/master@{#389900}
==========

[commit-bot: I haz the power, 2016-04-26 21:45:05]

Patchset 2 (id:??) landed as
https://crrev.com/42b8cf539dc33d653594e6d5ce1567a5b48f6efa
Cr-Commit-Position: refs/heads/master@{#389900}