Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1921563005: [Offline Pages] Remove obsolete synchronous API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add todo Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index fadcb9080a868264483ebb69387cb0251d064ebe..4da8bdc6f440583925e6246a77e1046ca01007ed 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -262,18 +262,6 @@ public class OfflinePageBridge {
nativeHasPages(mNativeOfflinePageBridge, namespace, callback);
}
- /**
- * Returns whether we have any offline pages at all.
- *
- * This function may return false even if there are pages saved on disk, depending on the state
- * of the OfflinePageModel.
- *
- * This function is deprecated. Use OfflinePageBridge#hasPages instead.
- */
- public boolean maybeHasPages(String namespace) {
- return nativeMaybeHasPages(mNativeOfflinePageBridge, namespace);
- }
-
/** @return A list of all offline ids that match a particular (namespace, client_id) pair. */
Set<Long> getOfflineIdsForClientId(ClientId clientId) {
assert mIsNativeOfflinePageModelLoaded;
@@ -476,17 +464,6 @@ public class OfflinePageBridge {
}
/**
- * @return Gets a list of pages that will be removed to clean up storage. Requires that the
- * model is already loaded.
- */
- public List<OfflinePageItem> getPagesToCleanUp() {
- assert mIsNativeOfflinePageModelLoaded;
- List<OfflinePageItem> result = new ArrayList<OfflinePageItem>();
- nativeGetPagesToCleanUp(mNativeOfflinePageBridge, result);
- return result;
- }
-
- /**
* Starts a check of offline page metadata, e.g. are all offline copies present.
*/
public void checkOfflinePageMetadata() {
@@ -612,7 +589,6 @@ public class OfflinePageBridge {
final MultipleOfflinePageItemCallback callback);
native void nativeHasPages(
long nativeOfflinePageBridge, String nameSpace, final HasPagesCallback callback);
- native boolean nativeMaybeHasPages(long nativeOfflinePageBridge, String nameSpace);
@VisibleForTesting
native long[] nativeGetOfflineIdsForClientId(
@@ -628,8 +604,6 @@ public class OfflinePageBridge {
WebContents webContents, String clientNamespace, String clientId);
private native void nativeDeletePages(
long nativeOfflinePageBridge, DeletePageCallback callback, long[] offlineIds);
- private native void nativeGetPagesToCleanUp(
- long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
private native void nativeCheckMetadataConsistency(long nativeOfflinePageBridge);
private native void nativeRecordStorageHistograms(long nativeOfflinePageBridge,
long totalSpaceInBytes, long freeSpaceInBytes, boolean reportingAfterDelete);
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698