Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1921563005: [Offline Pages] Remove obsolete synchronous API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add todo Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/offline_page_bridge.h" 5 #include "chrome/browser/android/offline_pages/offline_page_bridge.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 const JavaParamRef<jobject>& j_callback_obj) { 172 const JavaParamRef<jobject>& j_callback_obj) {
173 std::string name_space = ConvertJavaStringToUTF8(env, j_namespace); 173 std::string name_space = ConvertJavaStringToUTF8(env, j_namespace);
174 174
175 ScopedJavaGlobalRef<jobject> j_callback_ref; 175 ScopedJavaGlobalRef<jobject> j_callback_ref;
176 j_callback_ref.Reset(env, j_callback_obj); 176 j_callback_ref.Reset(env, j_callback_obj);
177 177
178 return offline_page_model_->HasPages( 178 return offline_page_model_->HasPages(
179 name_space, base::Bind(&HasPagesCallback, j_callback_ref)); 179 name_space, base::Bind(&HasPagesCallback, j_callback_ref));
180 } 180 }
181 181
182 bool OfflinePageBridge::MaybeHasPages(
183 JNIEnv* env,
184 const JavaParamRef<jobject>& obj,
185 const JavaParamRef<jstring>& j_namespace) {
186 std::string name_space = ConvertJavaStringToUTF8(env, j_namespace);
187 return offline_page_model_->MaybeHasPages(name_space);
188 }
189
190 void OfflinePageBridge::GetAllPages( 182 void OfflinePageBridge::GetAllPages(
191 JNIEnv* env, 183 JNIEnv* env,
192 const JavaParamRef<jobject>& obj, 184 const JavaParamRef<jobject>& obj,
193 const JavaParamRef<jobject>& j_result_obj, 185 const JavaParamRef<jobject>& j_result_obj,
194 const JavaParamRef<jobject>& j_callback_obj) { 186 const JavaParamRef<jobject>& j_callback_obj) {
195 DCHECK(j_result_obj); 187 DCHECK(j_result_obj);
196 DCHECK(j_callback_obj); 188 DCHECK(j_callback_obj);
197 189
198 ScopedJavaGlobalRef<jobject> j_result_ref; 190 ScopedJavaGlobalRef<jobject> j_result_ref;
199 j_result_ref.Reset(env, j_result_obj); 191 j_result_ref.Reset(env, j_result_obj);
200 192
201 ScopedJavaGlobalRef<jobject> j_callback_ref; 193 ScopedJavaGlobalRef<jobject> j_callback_ref;
202 j_callback_ref.Reset(env, j_callback_obj); 194 j_callback_ref.Reset(env, j_callback_obj);
203 195
204 offline_page_model_->GetAllPages( 196 offline_page_model_->GetAllPages(
205 base::Bind(&GetAllPagesCallback, j_result_ref, j_callback_ref)); 197 base::Bind(&GetAllPagesCallback, j_result_ref, j_callback_ref));
206 } 198 }
207 199
208 void OfflinePageBridge::GetPagesToCleanUp(
209 JNIEnv* env,
210 const JavaParamRef<jobject>& obj,
211 const JavaParamRef<jobject>& j_result_obj) {
212 DCHECK(offline_page_model_->is_loaded());
213 DCHECK(j_result_obj);
214 const std::vector<OfflinePageItem> offline_pages =
215 offline_page_model_->GetPagesToCleanUp();
216 ToJavaOfflinePageList(env, j_result_obj, offline_pages);
217 }
218
219 ScopedJavaLocalRef<jlongArray> OfflinePageBridge::GetOfflineIdsForClientId( 200 ScopedJavaLocalRef<jlongArray> OfflinePageBridge::GetOfflineIdsForClientId(
220 JNIEnv* env, 201 JNIEnv* env,
221 const JavaParamRef<jobject>& obj, 202 const JavaParamRef<jobject>& obj,
222 const JavaParamRef<jstring>& j_client_id_namespace, 203 const JavaParamRef<jstring>& j_client_id_namespace,
223 const JavaParamRef<jstring>& j_client_id) { 204 const JavaParamRef<jstring>& j_client_id) {
224 DCHECK(offline_page_model_->is_loaded()); 205 DCHECK(offline_page_model_->is_loaded());
225 offline_pages::ClientId client_id; 206 offline_pages::ClientId client_id;
226 client_id.name_space = ConvertJavaStringToUTF8(env, j_client_id_namespace); 207 client_id.name_space = ConvertJavaStringToUTF8(env, j_client_id_namespace);
227 client_id.id = ConvertJavaStringToUTF8(env, j_client_id); 208 client_id.id = ConvertJavaStringToUTF8(env, j_client_id);
228 209
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 ConvertUTF8ToJavaString(env, client_id.name_space).obj(), 338 ConvertUTF8ToJavaString(env, client_id.name_space).obj(),
358 ConvertUTF8ToJavaString(env, client_id.id).obj()); 339 ConvertUTF8ToJavaString(env, client_id.id).obj());
359 } 340 }
360 341
361 bool RegisterOfflinePageBridge(JNIEnv* env) { 342 bool RegisterOfflinePageBridge(JNIEnv* env) {
362 return RegisterNativesImpl(env); 343 return RegisterNativesImpl(env);
363 } 344 }
364 345
365 } // namespace android 346 } // namespace android
366 } // namespace offline_pages 347 } // namespace offline_pages
OLDNEW
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.h ('k') | components/offline_pages/offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698