[Offline Pages] Remove obsolete synchronous API methods.

components/offline_pages/offline_page_model.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 262 matching lines @@
 void OfflinePageModel::HasPages(const std::string& name_space,
                                 const HasPagesCallback& callback) {
   RunWhenLoaded(base::Bind(&OfflinePageModel::HasPagesAfterLoadDone,
                            weak_ptr_factory_.GetWeakPtr(), name_space,
                            callback));
 }
 
 void OfflinePageModel::HasPagesAfterLoadDone(
     const std::string& name_space,
     const HasPagesCallback& callback) const {
-  callback.Run(MaybeHasPages(name_space));
-}
+  DCHECK(is_loaded_);
 
-bool OfflinePageModel::MaybeHasPages(const std::string& name_space) const {
-  if (!is_loaded_)
-    return false;
+  bool has_pages = false;
 
   for (const auto& id_page_pair : offline_pages_) {
-    if (id_page_pair.second.client_id.name_space == name_space)
-      return true;
+    if (id_page_pair.second.client_id.name_space == name_space) {
+      has_pages = true;
+      break;
+    }
   }
 
-  return false;
+  callback.Run(has_pages);
 }
 
 void OfflinePageModel::GetAllPages(const GetAllPagesCallback& callback) {
   if (!is_loaded_) {
     delayed_tasks_.push_back(
         base::Bind(&OfflinePageModel::GetAllPagesAfterLoadDone,
                    weak_ptr_factory_.GetWeakPtr(), callback));
     return;
   }
 
   GetAllPagesAfterLoadDone(callback);
 }
 
 void OfflinePageModel::GetAllPagesAfterLoadDone(
     const GetAllPagesCallback& callback) {
   DCHECK(is_loaded_);
 
   std::vector<OfflinePageItem> offline_pages;
   for (const auto& id_page_pair : offline_pages_)
     offline_pages.push_back(id_page_pair.second);
 
   callback.Run(offline_pages);
 }
 
 const std::vector<OfflinePageItem> OfflinePageModel::GetPagesToCleanUp() const {

[jianli, 2016/04/25 22:41:31]

Do we also need to remove this?

[dewittj, 2016/04/25 22:56:55]

I have been leaving things like this and markpageaccessed since it seems likely
we will need the functionality for the automatic features we are shipping soon. 
Do you prefer removing it now?

[fgorski, 2016/04/26 03:20:50]

Put a TODO(fgorski): This needs an update as part of expiration policy work.

[dewittj, 2016/04/26 16:24:01]

Done.

   DCHECK(is_loaded_);
   std::vector<OfflinePageItem> offline_pages;
   base::Time now = base::Time::Now();
   for (const auto& id_page_pair : offline_pages_) {
     if (now - id_page_pair.second.last_access_time > kPageCleanUpThreshold)
       offline_pages.push_back(id_page_pair.second);
   }
   return offline_pages;
 }
 
@@ skipping 367 matching lines @@
 void OfflinePageModel::RunWhenLoaded(const base::Closure& task) {
   if (!is_loaded_) {
     delayed_tasks_.push_back(task);
     return;
   }
 
   task_runner_->PostTask(FROM_HERE, task);
 }
 
 }  // namespace offline_pages