Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and Permissions metrics.

Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520, 606645
Committed: https://crrev.com/07aeedd625a49a1d7276026f545961f26690629a
Cr-Commit-Position: refs/heads/master@{#390819}

[dominickn, 2016-04-26 04:19:49]

dominickn@chromium.org changed reviewers:
+ tsergeant@chromium.org

[dominickn, 2016-04-26 04:19:50]

tsergeant@: PTAL, thanks!

[tsergeant, 2016-04-26 04:40:51]

Cool, just a few nits

https://codereview.chromium.org/1921533004/diff/1/components/security_interst...
File components/security_interstitials/core/metrics_helper.h (right):

https://codereview.chromium.org/1921533004/diff/1/components/security_interst...
components/security_interstitials/core/metrics_helper.h:69: // (i.e. UMA or Safe
Browsing).
Nit: Align this line with the colon, like above.

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:43: a wide set of domains. Approval from Chrome
Privacy and rappor-dev is
Nit: How about "the Chrome Privacy and Rappor teams"?

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1696: **DEPRECATED: replaced by
interstitial.harmful2 of M52. The
Nit: "as of M52"

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1736: **DEPRECATED: replaced by
interstitial.malware2 of M52. The
"as of"

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1781: **DEPRECATED: replaced by
interstitial.phishing2 of M52. The
"as of"

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1835: **DEPRECATED: replaced by
interstitial.ssl2 of M52. The domain+registry
"as of"

[dominickn, 2016-04-26 05:38:40]

Description was changed from

==========
Add a RAPPOR configuration for low-frequency metrics, and use it for Safe
Browsing and Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520,606645
==========

to

==========
Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and
Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520,606645
==========

[dominickn, 2016-04-26 05:38:40]

dominickn@chromium.org changed reviewers:
+ felt@chromium.org, nparker@chromium.org

[dominickn, 2016-04-26 05:39:00]

dominickn@chromium.org changed reviewers:
+ holte@chromium.org

[dominickn, 2016-04-26 06:43:07]

Patchset #4 (id:60001) has been deleted

[dominickn, 2016-04-26 09:44:31]

Thanks!

@felt: PTAL at permissions and SSL

@nparker: PTAL at Safe Browsing

@holte: PTAL at metrics/ and the new RAPPOR configurations

https://codereview.chromium.org/1921533004/diff/1/components/security_interst...
File components/security_interstitials/core/metrics_helper.h (right):

https://codereview.chromium.org/1921533004/diff/1/components/security_interst...
components/security_interstitials/core/metrics_helper.h:69: // (i.e. UMA or Safe
Browsing).
On 2016/04/26 04:40:51, tsergeant wrote:
> Nit: Align this line with the colon, like above.

Done.

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:43: a wide set of domains. Approval from Chrome
Privacy and rappor-dev is
On 2016/04/26 04:40:51, tsergeant wrote:
> Nit: How about "the Chrome Privacy and Rappor teams"?

Done.

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1696: **DEPRECATED: replaced by
interstitial.harmful2 of M52. The
On 2016/04/26 04:40:51, tsergeant wrote:
> Nit: "as of M52"

Done.

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1736: **DEPRECATED: replaced by
interstitial.malware2 of M52. The
On 2016/04/26 04:40:51, tsergeant wrote:
> "as of"

Done.

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1781: **DEPRECATED: replaced by
interstitial.phishing2 of M52. The
On 2016/04/26 04:40:51, tsergeant wrote:
> "as of"

Done.

https://codereview.chromium.org/1921533004/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:1835: **DEPRECATED: replaced by
interstitial.ssl2 of M52. The domain+registry
On 2016/04/26 04:40:51, tsergeant wrote:
> "as of"

Done.

[Nathan Parker, 2016-04-28 20:42:26]

lgtm

for safe_browsing

[Nathan Parker, 2016-04-28 20:43:44]

oops, one nit

https://codereview.chromium.org/1921533004/diff/80001/components/rappor/rappo...
File components/rappor/rappor_parameters.h (right):

https://codereview.chromium.org/1921533004/diff/80001/components/rappor/rappo...
components/rappor/rappor_parameters.h:27: SAFEBROWSING_RAPPOR_TYPE,
Can you mark this one as deprecated in the comments?

[felt, 2016-04-28 23:40:44]

https://codereview.chromium.org/1921533004/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/1921533004/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_uma_util.cc:154: std::string rappor_metric
= deprecated_metric + "2";
I'm a little confused here. Why is recording the new metric dependent on the
deprecated metric (deprecated_metric.empty())?

[dominickn, 2016-04-29 07:14:45]

https://codereview.chromium.org/1921533004/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/1921533004/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_uma_util.cc:154: std::string rappor_metric
= deprecated_metric + "2";
On 2016/04/28 23:40:44, felt wrote:
> I'm a little confused here. Why is recording the new metric dependent on the
> deprecated metric (deprecated_metric.empty())?

Only because it's easier to append, rather that chop off "2" from the end of the
metric name. It's a little unnatural now, but when I remove the deprecated
metric, the new name will be returned from GetRapporMetric() and this will read
more cleanly. I've made the comment here a bit beefier to explain.

https://codereview.chromium.org/1921533004/diff/80001/components/rappor/rappo...
File components/rappor/rappor_parameters.h (right):

https://codereview.chromium.org/1921533004/diff/80001/components/rappor/rappo...
components/rappor/rappor_parameters.h:27: SAFEBROWSING_RAPPOR_TYPE,
On 2016/04/28 20:43:44, Nathan Parker wrote:
> Can you mark this one as deprecated in the comments?

Done.

[Steven Holte, 2016-04-29 16:21:50]

Sorry for the slow reply, I'm in Montreal this week. LGTM from the Rappor side.

[felt, 2016-04-29 22:27:41]

lgtm for /permissions/ and /ssl/

[dominickn, 2016-04-30 00:26:55]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-04-30 00:26:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1921533004/#ps100001
(title: "Addressing nits")

[commit-bot: I haz the power, 2016-04-30 00:27:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921533004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921533004/100001

[commit-bot: I haz the power, 2016-04-30 00:32:30]

Description was changed from

==========
Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and
Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520,606645
==========

to

==========
Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and
Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520,606645
==========

[commit-bot: I haz the power, 2016-04-30 00:32:32]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:30:31]

Patchset 5 (id:??) landed as
https://crrev.com/07aeedd625a49a1d7276026f545961f26690629a
Cr-Commit-Position: refs/heads/master@{#390819}

[commit-bot: I haz the power, 2016-04-30 18:03:44]

Description was changed from

==========
Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and
Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520,606645
==========

to

==========
Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and
Permissions metrics.

This CL implements a new RAPPOR configuration with the F privacy
parameter set to 0.25 instead of 0.5. This has the effect of introducing
less noise into the permanent random response, and thus preserving some
additional amount of signal. The reduction has been approved by the
Privacy team for low-frequency metrics (<500,000 reports per day) and
does not compromise user's privacy or anonymity.

This CL uses the new configuration for the permissions and Safe Browsing
metrics. The existing metrics for these configurations are retained for
a comparative analysis; they will be removed entirely in a future CL.
The multi-dimensional permissions metrics are removed in this CL as they
cannot be feasibly analysed.

Any other metrics which seek to use the new low-frequency configuration
must seek approval from the Metrics and Privacy teams.

BUG=598520,606645

Committed: https://crrev.com/07aeedd625a49a1d7276026f545961f26690629a
Cr-Commit-Position: refs/heads/master@{#390819}
==========