Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 1921533004: Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and Permissions metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.h ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 67eb6ae3a726a8266a3d723225030b632316724e..101fa5b97495430a32a220672099acdf38941bad 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -179,7 +179,11 @@ SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(
reporting_info.metric_prefix = GetMetricPrefix();
reporting_info.extra_suffix = GetExtraMetricsSuffix();
reporting_info.rappor_prefix = GetRapporPrefix();
- reporting_info.rappor_report_type = rappor::SAFEBROWSING_RAPPOR_TYPE;
+ reporting_info.deprecated_rappor_prefix = GetDeprecatedRapporPrefix();
+ reporting_info.rappor_report_type =
+ rappor::LOW_FREQUENCY_SAFEBROWSING_RAPPOR_TYPE;
+ reporting_info.deprecated_rappor_report_type =
+ rappor::SAFEBROWSING_RAPPOR_TYPE;
set_metrics_helper(base::WrapUnique(new ChromeMetricsHelper(
web_contents, request_url(), reporting_info, GetSamplingEventName())));
metrics_helper()->RecordUserDecision(
@@ -568,6 +572,19 @@ std::string SafeBrowsingBlockingPage::GetExtraMetricsSuffix() const {
std::string SafeBrowsingBlockingPage::GetRapporPrefix() const {
switch (interstitial_reason_) {
case SB_REASON_MALWARE:
+ return "malware2";
+ case SB_REASON_HARMFUL:
+ return "harmful2";
+ case SB_REASON_PHISHING:
+ return "phishing2";
+ }
+ NOTREACHED();
+ return std::string();
+}
+
+std::string SafeBrowsingBlockingPage::GetDeprecatedRapporPrefix() const {
+ switch (interstitial_reason_) {
+ case SB_REASON_MALWARE:
return "malware";
case SB_REASON_HARMFUL:
return "harmful";
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.h ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698