Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 1921533004: Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and Permissions metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | components/rappor/rappor_parameters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 0d275561cf6956faeaef281ff2db6b6afb0ad879..89b20db7c0d4eb01bd1282ab742a828d4e779900 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -61,7 +61,8 @@ enum SSLExpirationAndDecision {
// Rappor prefix, which is used for both overridable and non-overridable
// interstitials so we don't leak the "overridable" bit.
-const char kSSLRapporPrefix[] = "ssl2";
+const char kDeprecatedSSLRapporPrefix[] = "ssl2";
+const char kSSLRapporPrefix[] = "ssl3";
std::string GetSamplingEventName(const bool overridable, const int cert_error) {
std::string event_name(kEventNameBase);
@@ -142,7 +143,9 @@ SSLBlockingPage::SSLBlockingPage(
reporting_info.metric_prefix =
overridable_ ? "ssl_overridable" : "ssl_nonoverridable";
reporting_info.rappor_prefix = kSSLRapporPrefix;
- reporting_info.rappor_report_type = rappor::UMA_RAPPOR_TYPE;
+ reporting_info.deprecated_rappor_prefix = kDeprecatedSSLRapporPrefix;
+ reporting_info.rappor_report_type = rappor::LOW_FREQUENCY_UMA_RAPPOR_TYPE;
+ reporting_info.deprecated_rappor_report_type = rappor::UMA_RAPPOR_TYPE;
ChromeMetricsHelper* chrome_metrics_helper =
new ChromeMetricsHelper(web_contents, request_url, reporting_info,
GetSamplingEventName(overridable_, cert_error));
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | components/rappor/rappor_parameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698