Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: ios/chrome/browser/ssl/ios_ssl_blocking_page.mm

Issue 1921533004: Add a low-frequency RAPPOR configuration, and use it for Safe Browsing and Permissions metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/security_interstitials/core/metrics_helper.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ssl/ios_ssl_blocking_page.mm
diff --git a/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm b/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm
index d283a95c256a5695cc2f7d2ceb775ac3b3371ffb..b689c5981214d619321340a39d5d9d1b1cd6d43d 100644
--- a/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm
+++ b/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm
@@ -40,7 +40,8 @@ enum SSLExpirationAndDecision {
// Rappor prefix, which is used for both overridable and non-overridable
// interstitials so we don't leak the "overridable" bit.
-const char kSSLRapporPrefix[] = "ssl2";
+const char kDeprecatedSSLRapporPrefix[] = "ssl2";
+const char kSSLRapporPrefix[] = "ssl3";
void RecordSSLExpirationPageEventState(bool expired_but_previously_allowed,
bool proceed,
@@ -95,7 +96,9 @@ IOSSSLBlockingPage::IOSSSLBlockingPage(
reporting_info.metric_prefix =
overridable_ ? "ssl_overridable" : "ssl_nonoverridable";
reporting_info.rappor_prefix = kSSLRapporPrefix;
- reporting_info.rappor_report_type = rappor::UMA_RAPPOR_TYPE;
+ reporting_info.deprecated_rappor_prefix = kDeprecatedSSLRapporPrefix;
+ reporting_info.rappor_report_type = rappor::LOW_FREQUENCY_UMA_RAPPOR_TYPE;
+ reporting_info.deprecated_rappor_report_type = rappor::UMA_RAPPOR_TYPE;
IOSChromeMetricsHelper* ios_chrome_metrics_helper =
new IOSChromeMetricsHelper(web_state, request_url, reporting_info);
controller_->set_metrics_helper(base::WrapUnique(ios_chrome_metrics_helper));
« no previous file with comments | « components/security_interstitials/core/metrics_helper.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698