third_party/WebKit/Source/platform/v8_inspector/V8Console.h - Issue 1921143002: [DevTools] Align Console implementation with The JSey way

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.h

Issue 1921143002: [DevTools] Align Console implementation with The JSey way (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h

index 83489da462bf6461d0b4a808f18e1beda20afc61..bd5fb8cd296fe175832fe855974b7853781f6539 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h

@@ -15,7 +15,7 @@ class InspectedContext;

// https://console.spec.whatwg.org/#console-interface

class V8Console {

public:

- static v8::MaybeLocal<v8::Object> createConsole(InspectedContext*, bool hasMemoryAttribute);

+ static v8::Local<v8::Object> createConsole(InspectedContext*, bool hasMemoryAttribute);

static v8::Local<v8::Object> createCommandLineAPI(InspectedContext*);

static void clearInspectedContextIfNeeded(v8::Local<v8::Context>, v8::Local<v8::Object> console);