third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h - Issue 1921143002: [DevTools] Align Console implementation with The JSey way

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 1921143002: [DevTools] Align Console implementation with The JSey way (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

index 24fc0eb92a7e93fd1d3ac4bfe2f30ca48fd0e9e4..6b75f42a7f1c6bc417e5b65d8e353c5bb69e8708 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

@@ -64,10 +64,8 @@ private:

int callV8FunctionReturnInt(const char* name) const;

v8::Isolate* m_isolate;

- OwnPtr<JavaScriptCallFrame> m_caller;

v8::Global<v8::Context> m_debuggerContext;

v8::Global<v8::Object> m_callFrame;

- v8::Global<v8::FunctionTemplate> m_wrapperTemplate;

};

using JavaScriptCallFrames = protocol::Vector<OwnPtr<JavaScriptCallFrame>>;