third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp - Issue 1921143002: [DevTools] Align Console implementation with The JSey way

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

Issue 1921143002: [DevTools] Align Console implementation with The JSey way (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt ('k') | third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

index b00a55d4fac1953c2e49d96da996f673fdb0956c..49cbf653d4d9c53995e31d7c01bea91739275652 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

@@ -44,9 +44,7 @@ InspectedContext::InspectedContext(V8DebuggerImpl* debugger, const V8ContextInfo

v8::Isolate* isolate = m_debugger->isolate();

v8::Local<v8::Object> global = info.context->Global();

- v8::Local<v8::Object> console;

- if (!V8Console::createConsole(this, info.hasMemoryOnConsole).ToLocal(&console))

- return;

+ v8::Local<v8::Object> console = V8Console::createConsole(this, info.hasMemoryOnConsole);

if (!global->Set(info.context, toV8StringInternalized(isolate, "console"), console).FromMaybe(false))

return;

m_console.Reset(isolate, console);