Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 1920693002: Complete //device/bt implementation for hosting local GATT attributes. (Closed)

Created:
4 years, 8 months ago by rkc
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete //device/bt implementation for hosting local GATT attributes. This CL completes the implementation of all the parts required for hosting local GATT attributes. Since the size of this CL is unweildy, it is being broken down into multiple CLs, which can be reviewed more easily. Please do not leave comments on this patch. It is only for reference and is not being updated with any fixes.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2306 lines, -435 lines) Patch
M device/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 3 chunks +10 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 3 chunks +10 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 3 chunks +22 lines, -19 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 7 chunks +48 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_characteristic.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_characteristic.cc View 2 chunks +15 lines, -7 lines 0 comments Download
A device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc View 1 1 chunk +80 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_descriptor.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_descriptor.cc View 2 chunks +14 lines, -5 lines 0 comments Download
A device/bluetooth/bluetooth_local_gatt_descriptor_unittest.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_service.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 5 chunks +34 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 1 5 chunks +96 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_characteristic_bluez.h View 1 chunk +2 lines, -3 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_characteristic_bluez.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A device/bluetooth/bluez/bluetooth_gatt_characteristic_delegate_wrapper.h View 1 chunk +49 lines, -0 lines 0 comments Download
A device/bluetooth/bluez/bluetooth_gatt_characteristic_delegate_wrapper.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.h View 2 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.cc View 1 chunk +1 line, -3 lines 0 comments Download
A device/bluetooth/bluez/bluetooth_gatt_descriptor_delegate_wrapper.h View 1 chunk +49 lines, -0 lines 0 comments Download
A device/bluetooth/bluez/bluetooth_gatt_descriptor_delegate_wrapper.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_service_bluez.h View 3 chunks +39 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_service_bluez.cc View 3 chunks +22 lines, -20 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.h View 2 chunks +39 lines, -5 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.cc View 2 chunks +50 lines, -3 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_descriptor_bluez.h View 1 chunk +27 lines, -6 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_descriptor_bluez.cc View 1 chunk +38 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.h View 5 chunks +24 lines, -3 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.cc View 3 chunks +12 lines, -19 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_remote_gatt_descriptor_bluez.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A device/bluetooth/dbus/bluetooth_gatt_application_service_provider.h View 1 1 chunk +65 lines, -0 lines 0 comments Download
A device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
A device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h View 1 1 chunk +112 lines, -0 lines 0 comments Download
A device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.cc View 1 1 chunk +162 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h View 3 chunks +12 lines, -43 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.cc View 11 chunks +34 lines, -26 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_descriptor_service_provider.h View 3 chunks +11 lines, -41 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_descriptor_service_provider.cc View 10 chunks +30 lines, -22 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_manager_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_manager_client.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider.h View 2 chunks +6 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider.cc View 4 chunks +10 lines, -9 lines 0 comments Download
A device/bluetooth/dbus/fake_bluetooth_gatt_application_service_provider.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
A device/bluetooth/dbus/fake_bluetooth_gatt_application_service_provider.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_client.cc View 8 chunks +22 lines, -19 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.h View 4 chunks +18 lines, -10 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc View 6 chunks +15 lines, -13 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc View 2 chunks +7 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_service_provider.h View 4 chunks +17 lines, -10 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_service_provider.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_manager_client.h View 4 chunks +60 lines, -31 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_manager_client.cc View 6 chunks +133 lines, -53 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_service_provider.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A device/bluetooth/test/bluetooth_gatt_server_test.h View 1 1 chunk +112 lines, -0 lines 0 comments Download
A device/bluetooth/test/bluetooth_gatt_server_test.cc View 1 1 chunk +162 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 3 chunks +41 lines, -3 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.h View 2 chunks +32 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.cc View 3 chunks +143 lines, -8 lines 0 comments Download
M device/device_tests.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920693002/20001
4 years, 8 months ago (2016-04-25 00:04:12 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 01:15:27 UTC) #4
Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698