Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_manager_client.cc

Issue 1920693002: Complete //device/bt implementation for hosting local GATT attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/dbus/bluetooth_gatt_manager_client.cc
diff --git a/device/bluetooth/dbus/bluetooth_gatt_manager_client.cc b/device/bluetooth/dbus/bluetooth_gatt_manager_client.cc
index 2f8891049b260559ae8c879cae1c59bc16450e93..afa103a06dbf77a760d4470313b4abf6849cc593 100644
--- a/device/bluetooth/dbus/bluetooth_gatt_manager_client.cc
+++ b/device/bluetooth/dbus/bluetooth_gatt_manager_client.cc
@@ -26,20 +26,20 @@ class BluetoothGattManagerClientImpl : public BluetoothGattManagerClient {
~BluetoothGattManagerClientImpl() override {}
// BluetoothGattManagerClient override.
- void RegisterService(const dbus::ObjectPath& service_path,
- const Options& options,
- const base::Closure& callback,
- const ErrorCallback& error_callback) override {
+ void RegisterApplication(const dbus::ObjectPath& application_path,
+ const Options& options,
+ const base::Closure& callback,
+ const ErrorCallback& error_callback) override {
dbus::MethodCall method_call(
bluetooth_gatt_manager::kBluetoothGattManagerInterface,
bluetooth_gatt_manager::kRegisterService);
dbus::MessageWriter writer(&method_call);
- writer.AppendObjectPath(service_path);
+ writer.AppendObjectPath(application_path);
- // TODO(armansito): The parameters of the Options dictionary are undefined
- // but the method signature still requires a value dictionary. Pass an
- // empty dictionary and fill in the contents later once this is defined.
+ // The parameters of the Options dictionary are undefined but the method
+ // signature still requires a value dictionary. Pass an empty dictionary
+ // and fill in the contents later if and when we add any options.
dbus::MessageWriter array_writer(NULL);
writer.OpenArray("{sv}", &array_writer);
writer.CloseContainer(&array_writer);
@@ -54,15 +54,15 @@ class BluetoothGattManagerClientImpl : public BluetoothGattManagerClient {
}
// BluetoothGattManagerClient override.
- void UnregisterService(const dbus::ObjectPath& service_path,
- const base::Closure& callback,
- const ErrorCallback& error_callback) override {
+ void UnregisterApplication(const dbus::ObjectPath& application_path,
+ const base::Closure& callback,
+ const ErrorCallback& error_callback) override {
dbus::MethodCall method_call(
bluetooth_gatt_manager::kBluetoothGattManagerInterface,
bluetooth_gatt_manager::kUnregisterService);
dbus::MessageWriter writer(&method_call);
- writer.AppendObjectPath(service_path);
+ writer.AppendObjectPath(application_path);
DCHECK(object_proxy_);
object_proxy_->CallMethodWithErrorCallback(
« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_manager_client.h ('k') | device/bluetooth/dbus/bluetooth_gatt_service_service_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698